Would it be a good idea to consider putting this app on F-Droid #50

d-RealMusic-b · 2024-01-06T16:21:18Z

Magisk and KernelSU are both up on f-droid for download, so why not APatch? And here is F-Droid's inclusion policy, I think APatch is in line with their policy.

linsui · 2024-02-13T03:55:20Z

KernelSU is not on F-Droid, at least not in the official repo. The Magisk build metadata for F-Droid is maintained by me. If APatch agrees to be included, I can help.

d-RealMusic-b · 2024-02-13T04:10:52Z

KernelSU is not on F-Droid, at least not in the official repo. The Magisk build metadata for F-Droid is maintained by me. If APatch agrees to be included, I can help.

I was mistaken, KernelSU is currently in the lzzyOnDroid F-Droid Repo. Thanks for your work, hopefully we'll see APatch in F-Droid too.

bmax121 · 2024-03-08T09:26:40Z

I agree, if it doesn't inconvenience you too much.

bmax121 · 2024-03-08T09:26:47Z

@linsui

linsui · 2024-03-08T16:42:06Z

I'll have a try. Looks like we need to build magisk first for these libs in https://github.com/bmax121/APatch/tree/main/app/libs/arm64-v8a. But it seems libmagiskpolicy.so is from a different version of magisk?

pomelohan · 2024-03-09T12:12:01Z

I'll have a try. Looks like we need to build magisk first for these libs in https://github.com/bmax121/APatch/tree/main/app/libs/arm64-v8a. But it seems libmagiskpolicy.so is from a different version of magisk?

Yes, it was a modified version, so that magiskpolicy can compatible with APatch

linsui · 2024-03-09T13:05:04Z

Where is the source code of the modified version?

pomelohan · 2024-03-10T23:37:15Z

Where is the source code of the modified version?

Wait for @bmax121 upload patiently.

Btw, should the modified magiskpolicy being built together with APatch? If true, we may need hack gradle to do that.

linsui · 2024-03-11T06:05:08Z

Btw, should the modified magiskpolicy being built together with APatch? If true, we may need hack gradle to do that.

It needs to be built from source. We can build it first then put it in the required location.

pomelohan · 2024-03-14T15:22:09Z

Btw, should the modified magiskpolicy being built together with APatch? If true, we may need hack gradle to do that.

It needs to be built from source. We can build it first then put it in the required location.

Sorry for the delay and thanks for supporting APatch. We’re currently working on developing these days so didn’t reply on time. We will notify you once we finished that. ;)

bmax121 · 2024-03-15T02:41:40Z

The source is at https://github.com/bmax121/Magisk,
Mainly changed this file: https://github.com/bmax121/Magisk/blob/master/native/src/sepolicy/rules.cpp

linsui · 2024-03-15T04:48:49Z

Which commit do you use? I didn't see any change on master branch.

bmax121 · 2024-03-15T14:22:34Z

It's ok now
bmax121/Magisk@cc94f7b

linsui · 2024-03-18T14:02:13Z

IIUC, APatch doesn't use ONDK to build the rust code. Then does it make sense to build the magisk libs with ONDK? I have to rebuild ONDK from source so if it's not needed maybe I can skip that step.

linsui · 2024-03-18T14:24:27Z

What is the downloaded compiler in https://github.com/bmax121/KernelPatch/blob/main/.github/workflows/build.yml used for? Is there any simple way to build those kernel patch binaries?

shuvashish76 · 2024-05-14T01:15:57Z

@bmax121 Requested at IzzyOnDroid.
According to their scanner report

No offending libs found.


Dangerous flags:
----------------
* usesCleartextTraffic

Permissions:
------------
* android.permission.INTERNET
* android.permission.WRITE_EXTERNAL_STORAGE
* android.permission.READ_EXTERNAL_STORAGE
* android.permission.QUERY_ALL_PACKAGES
* me.bmax.apatch.DYNAMIC_RECEIVER_NOT_EXPORTED_PERMISSION

Need some clarification regarding usesCleartextTraffic and QUERY_ALL_PACKAGES

pomelohan · 2024-05-15T01:58:52Z

@bmax121 Requested at IzzyOnDroid. According to their scanner report

No offending libs found.


Dangerous flags:
----------------
* usesCleartextTraffic

Permissions:
------------
* android.permission.INTERNET
* android.permission.WRITE_EXTERNAL_STORAGE
* android.permission.READ_EXTERNAL_STORAGE
* android.permission.QUERY_ALL_PACKAGES
* me.bmax.apatch.DYNAMIC_RECEIVER_NOT_EXPORTED_PERMISSION

Need some clarification regarding usesCleartextTraffic and QUERY_ALL_PACKAGES

Hey shuvashish76 Thank you for your contribution.

usesCleartextTraffic is for APatch Module WebUI feature and QUERY_ALL_PACKAGES is being used for selecting SuperUsers Applications. Are those enough? Feel free to notify me if you need more clarification ;)

pomelohan · 2024-05-15T02:00:14Z

What is the downloaded compiler in https://github.com/bmax121/KernelPatch/blob/main/.github/workflows/build.yml used for? Is there any simple way to build those kernel patch binaries?

Used for compiling kpimg, no more simple way but use this compiler because other one may lead to kpimg broken.

shuvashish76 · 2024-05-15T02:13:43Z

@pomelohan Thanks. Please add Fastlane metadata as mentioned here. (Necessary for both F-Droid / IzzyOnDroid)

linsui · 2024-05-15T06:44:05Z

Used for compiling kpimg, no more simple way but use this compiler because other one may lead to kpimg broken.

Where is this special gcc from? How can I build it?

shuvashish76 · 2024-05-15T07:53:22Z

usesCleartextTraffic is for APatch Module WebUI feature

usesCleartextTraffic is only used locally on-device (and not to reach out to the internet)? Is that ensured e.g. via a "network security police"?

pomelohan · 2024-05-22T14:22:16Z

Used for compiling kpimg, no more simple way but use this compiler because other one may lead to kpimg broken.

Where is this special gcc from? How can I build it?

Sorry for the delay, busy those days...

Update: No need special gcc, only aarch64-elf gcc is required. But it's better to use the same gcc version as KernelPatch using.

pomelohan · 2024-05-22T14:24:34Z

usesCleartextTraffic is for APatch Module WebUI feature

usesCleartextTraffic is only used locally on-device (and not to reach out to the internet)? Is that ensured e.g. via a "network security police"?

Sorry for the delay, busy those days...

Yes, usesCleartextTraffic is only used locally on-device. (Located on: /data/adb/modules/<module>/webroot, it is providing an interface for a
module to control itself). It wouldn't reach out to the internet unless module author do that.

linsui · 2024-05-22T14:40:11Z

Update: No need special gcc, only aarch64-elf gcc is required. But it's better to use the same gcc version as KernelPatch using.

Am I understand it correctly that I just need an aarch64-elf gcc for all the build related to kernel patch?

pomelohan · 2024-05-22T14:45:13Z

Update: No need special gcc, only aarch64-elf gcc is required. But it's better to use the same gcc version as KernelPatch using.

Am I understand it correctly that I just need an aarch64-elf gcc for all the build related to kernel patch?

Yes, but it is recommended to use the same gcc version as KernelPatch CI using because KernelPatch Project is special, unlike other programs. Newer or old version may lead to issues because of optimizations.

marat2509 · 2024-05-23T00:02:30Z

Thanks! That only leaves the storage permissions then which could use a short explanation, too 😉

@bmax121 @pomelohan

linsui · 2024-05-23T07:32:00Z

Yes, but it is recommended to use the same gcc version as KernelPatch CI using because KernelPatch Project is special, unlike other programs. Newer or old version may lead to issues because of optimizations.

Can I use this package? Or I should build the aarch64-elf-gcc somehow? I'm not sure what the difference is.

pomelohan · 2024-05-23T12:30:35Z

Yes, but it is recommended to use the same gcc version as KernelPatch CI using because KernelPatch Project is special, unlike other programs. Newer or old version may lead to issues because of optimizations.

Can I use this package? Or I should build the aarch64-elf-gcc somehow? I'm not sure what the difference is.

I thought this version maybe too old to make KernelPatch working. KernelPatch CI is using this one:
https://armkeil.blob.core.windows.net/developer/Files/downloads/gnu/12.2.rel1/binrel/arm-gnu-toolchain-12.2.rel1-x86_64-aarch64-none-elf.tar.xz

linsui · 2024-05-23T12:32:25Z

I thought both of them are GCC 12.2?

pomelohan · 2024-05-23T12:34:22Z

Thanks! That only leaves the storage permissions then which could use a short explanation, too 😉

@bmax121 @pomelohan

storage permissions are used to store patched boot image and module upgrading🌹

pomelohan · 2024-05-23T12:40:27Z

I thought both of them are GCC 12.2?

Sorry I didn’t notice the version. I thought it was OK if version is 12.2 xD

linsui · 2024-05-23T12:42:53Z

Sorry I didn’t notice the version. I thought it was OK if version is 12.2 xD

So I can just use the gcc-linux-gnu? That's great. So the elf target is not necessary? Do I need any special configuration?

pomelohan · 2024-05-23T12:59:47Z

gcc-linux-gnu

Yes have a try, author said maybe working😂

linsui · 2024-05-23T13:02:00Z

Yes have a try, author said maybe working😂

OK. 😂

marat2509 · 2024-05-26T01:42:13Z

Released to https://apt.izzysoft.de/fdroid/index/apk/me.bmax.apatch

linsui · 2024-05-26T16:32:52Z

Yes have a try, author said maybe working😂

https://gitlab.com/linsui/fdroiddata/-/jobs/6942666334 Does this mean that it doesn't work?

pomelohan · 2024-05-26T22:11:51Z

Yes have a try, author said maybe working😂

https://gitlab.com/linsui/fdroiddata/-/jobs/6942666334 Does this mean that it doesn't work?

Yes, kpimg.elf is necessary. Can’t we use prebuilt toolchain like the one KernelPatch using?

marat2509 added the enhancement New feature or request label Jan 6, 2024

pomelohan assigned bmax121 Mar 14, 2024

Would it be a good idea to consider putting this app on F-Droid #50

Would it be a good idea to consider putting this app on F-Droid #50

Comments

d-RealMusic-b commented Jan 6, 2024

linsui commented Feb 13, 2024

d-RealMusic-b commented Feb 13, 2024 • edited

bmax121 commented Mar 8, 2024

bmax121 commented Mar 8, 2024

linsui commented Mar 8, 2024

pomelohan commented Mar 9, 2024

linsui commented Mar 9, 2024

pomelohan commented Mar 10, 2024

linsui commented Mar 11, 2024

pomelohan commented Mar 14, 2024

bmax121 commented Mar 15, 2024 • edited

linsui commented Mar 15, 2024

bmax121 commented Mar 15, 2024 • edited

linsui commented Mar 18, 2024

linsui commented Mar 18, 2024

shuvashish76 commented May 14, 2024

pomelohan commented May 15, 2024

pomelohan commented May 15, 2024

shuvashish76 commented May 15, 2024 • edited

linsui commented May 15, 2024

shuvashish76 commented May 15, 2024

pomelohan commented May 22, 2024 • edited

pomelohan commented May 22, 2024 • edited

linsui commented May 22, 2024

pomelohan commented May 22, 2024 • edited

marat2509 commented May 23, 2024 • edited

linsui commented May 23, 2024

pomelohan commented May 23, 2024

linsui commented May 23, 2024

pomelohan commented May 23, 2024

pomelohan commented May 23, 2024

linsui commented May 23, 2024 • edited

pomelohan commented May 23, 2024

linsui commented May 23, 2024

marat2509 commented May 26, 2024

linsui commented May 26, 2024

pomelohan commented May 26, 2024

d-RealMusic-b commented Feb 13, 2024 •

edited

bmax121 commented Mar 15, 2024 •

edited

bmax121 commented Mar 15, 2024 •

edited

shuvashish76 commented May 15, 2024 •

edited

pomelohan commented May 22, 2024 •

edited

pomelohan commented May 22, 2024 •

edited

pomelohan commented May 22, 2024 •

edited

marat2509 commented May 23, 2024 •

edited

linsui commented May 23, 2024 •

edited