Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove () in Logger.apply[C: ClassTag]() method? #40

Open
floating-cat opened this issue Jun 26, 2020 · 0 comments
Open

Remove () in Logger.apply[C: ClassTag]() method? #40

floating-cat opened this issue Jun 26, 2020 · 0 comments

Comments

@floating-cat
Copy link

floating-cat commented Jun 26, 2020

The Scala 2.13.3 deprecates auto-application of (non-Java-defined) methods with a single empty parameter list: scala/scala#8833.

So the below example in the documentation doesn't work anymore (without suppressing the warning):

class Foo {
  val logger = Logger[this.type] // or Logger[Foo]
}

Would it better to remove the () in Logger.apply[C: ClassTag]() method here:
https://github.com/bmc/grizzled-slf4j/blob/master/src/main/scala/grizzled/slf4j/slf4j.scala#L434 ?
Then we could still use Logger[this.type] in our code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant