New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[builder] Convert Bndtools builder to a facade pattern #5004

Closed

kriegfrj opened this issue Dec 20, 2021 · 4 comments · May be fixed by #5036

Assignees

Labels

abeyance

Milestone

Contributor

kriegfrj commented Dec 20, 2021

In order to streamline future development on the Bndtools builder (eg, #3175), I would like to convert it to a facade pattern so that the builder bundle can be restarted without needing to restart Eclipse. Creating this issue to hang a corresponding commit/PR from.

kriegfrj mentioned this issue

[validator] Project/builder validators not generating markers #5006

Closed

Member

bjhargrave commented Dec 20, 2021

Care is needed since this is the crux of the Bndtools value.

kriegfrj mentioned this issue

[validators] Fix marker generation for validators #5008

Merged

kriegfrj closed this as completed

kriegfrj reopened this

kriegfrj mentioned this issue

[builder] Regression tests for BndtoolsBuilder #5011

Closed

kriegfrj mentioned this issue

[tester] Start synchronization mechanism #5022

Closed

kriegfrj added a commit to kriegfrj/bnd that referenced this issue


          [core] Made Central a service

953fbd0

Part of bndtools#5004

Signed-off-by: Fr Jeremy Krieg <fr.jkrieg@greekwelfaresa.org.au>

kriegfrj added a commit to kriegfrj/bnd that referenced this issue


          [builder] Change BndtoolsBuilder to facade pattern

b744f0f

Fixes bndtools#5004

Signed-off-by: Fr Jeremy Krieg <fr.jkrieg@greekwelfaresa.org.au>

kriegfrj added a commit to kriegfrj/bnd that referenced this issue


          [validators] Change validators to use services.

6c94f95

Partially fixes bndtools#5005, bndtools#5004.

Signed-off-by: Fr Jeremy Krieg <fr.jkrieg@greekwelfaresa.org.au>

kriegfrj added a commit to kriegfrj/bnd that referenced this issue


          [core] Made Central a service

3fe34bd

Part of bndtools#5004

Signed-off-by: Fr Jeremy Krieg <fr.jkrieg@greekwelfaresa.org.au>

kriegfrj added a commit to kriegfrj/bnd that referenced this issue


          [builder] Change BndtoolsBuilder to facade pattern

5187df6

Fixes bndtools#5004

Signed-off-by: Fr Jeremy Krieg <fr.jkrieg@greekwelfaresa.org.au>

kriegfrj added a commit to kriegfrj/bnd that referenced this issue


          [validators] Change validators to use services.

6539d05

Partially fixes bndtools#5005, bndtools#5004.

Signed-off-by: Fr Jeremy Krieg <fr.jkrieg@greekwelfaresa.org.au>

kriegfrj added a commit to kriegfrj/bnd that referenced this issue


          [builder] Change BndtoolsBuilder to facade pattern

79fb275

Fixes bndtools#5004

Signed-off-by: Fr Jeremy Krieg <fr.jkrieg@greekwelfaresa.org.au>

kriegfrj added a commit to kriegfrj/bnd that referenced this issue


          [validators] Change validators to use services.

1f152e2

Partially fixes bndtools#5005, bndtools#5004.

Signed-off-by: Fr Jeremy Krieg <fr.jkrieg@greekwelfaresa.org.au>

kriegfrj mentioned this issue

[builder] Change to facade #5036

Draft

kriegfrj added a commit to kriegfrj/bnd that referenced this issue


          [builder] Change BndtoolsBuilder to facade pattern

017eef9

Fixes bndtools#5004

Signed-off-by: Fr Jeremy Krieg <fr.jkrieg@greekwelfaresa.org.au>

kriegfrj added a commit to kriegfrj/bnd that referenced this issue


          [validators] Change validators to use services.

37c951f

Partially fixes bndtools#5005, bndtools#5004.

Signed-off-by: Fr Jeremy Krieg <fr.jkrieg@greekwelfaresa.org.au>

kriegfrj added a commit to kriegfrj/bnd that referenced this issue


          [builder] Change BndtoolsBuilder to facade pattern

6260a75

Fixes bndtools#5004

Signed-off-by: Fr Jeremy Krieg <fr.jkrieg@greekwelfaresa.org.au>

kriegfrj added a commit to kriegfrj/bnd that referenced this issue


          [validators] Change validators to use services.

896f029

Partially fixes bndtools#5005, bndtools#5004.

Signed-off-by: Fr Jeremy Krieg <fr.jkrieg@greekwelfaresa.org.au>

kriegfrj added a commit to kriegfrj/bnd that referenced this issue


          [core] Made Central a service

75dbe39

Part of bndtools#5004

Signed-off-by: Fr Jeremy Krieg <fr.jkrieg@greekwelfaresa.org.au>

kriegfrj added a commit to kriegfrj/bnd that referenced this issue


          [builder] Change BndtoolsBuilder to facade pattern

48bbeef

Fixes bndtools#5004

Signed-off-by: Fr Jeremy Krieg <fr.jkrieg@greekwelfaresa.org.au>

kriegfrj added a commit to kriegfrj/bnd that referenced this issue


          [validators] Change validators to use services.

2fbbd0d

Partially fixes bndtools#5005, bndtools#5004.

Signed-off-by: Fr Jeremy Krieg <fr.jkrieg@greekwelfaresa.org.au>

kriegfrj added a commit to kriegfrj/bnd that referenced this issue


          [core] Made Central a service

211025b

Part of bndtools#5004

Signed-off-by: Fr Jeremy Krieg <fr.jkrieg@greekwelfaresa.org.au>

kriegfrj added a commit to kriegfrj/bnd that referenced this issue


          [builder] Change BndtoolsBuilder to facade pattern

54f1cce

Fixes bndtools#5004

Signed-off-by: Fr Jeremy Krieg <fr.jkrieg@greekwelfaresa.org.au>

kriegfrj added a commit to kriegfrj/bnd that referenced this issue


          [validators] Change validators to use services

f4c05e6

Partially fixes bndtools#5005, bndtools#5004.

Signed-off-by: Fr Jeremy Krieg <fr.jkrieg@greekwelfaresa.org.au>

kriegfrj added a commit to kriegfrj/bnd that referenced this issue


          [validators] Change validators to use services

727b834

Partially fixes bndtools#5005, bndtools#5004.

Signed-off-by: Fr Jeremy Krieg <fr.jkrieg@greekwelfaresa.org.au>

kriegfrj added a commit to kriegfrj/bnd that referenced this issue


          [builder] Change BndtoolsBuilder to facade pattern

9f02831

Fixes bndtools#5004

Signed-off-by: Fr Jeremy Krieg <fr.jkrieg@greekwelfaresa.org.au>

kriegfrj added a commit to kriegfrj/bnd that referenced this issue


          [validators] Change validators to use services

593e410

Partially fixes bndtools#5005, bndtools#5004.

Signed-off-by: Fr Jeremy Krieg <fr.jkrieg@greekwelfaresa.org.au>

kriegfrj added a commit to kriegfrj/bnd that referenced this issue


          [builder] Change BndtoolsBuilder to facade pattern

78fb15e

Fixes bndtools#5004

Signed-off-by: Fr Jeremy Krieg <fr.jkrieg@greekwelfaresa.org.au>

kriegfrj added a commit to kriegfrj/bnd that referenced this issue


          [validators] Change validators to use services

9d59c42

Partially fixes bndtools#5005, bndtools#5004.

Signed-off-by: Fr Jeremy Krieg <fr.jkrieg@greekwelfaresa.org.au>

bjhargrave assigned kriegfrj

bjhargrave added this to the 6.3 milestone

kriegfrj added a commit to kriegfrj/bnd that referenced this issue


          [core] Made Central a service

01e5e25

Part of bndtools#5004

Signed-off-by: Fr Jeremy Krieg <fr.jkrieg@greekwelfaresa.org.au>

kriegfrj added a commit to kriegfrj/bnd that referenced this issue


          [builder] Change BndtoolsBuilder to facade pattern

91035ff

Fixes bndtools#5004

Signed-off-by: Fr Jeremy Krieg <fr.jkrieg@greekwelfaresa.org.au>

kriegfrj added a commit to kriegfrj/bnd that referenced this issue


          [validators] Change validators to use services

a870b47

Partially fixes bndtools#5005, bndtools#5004.

Signed-off-by: Fr Jeremy Krieg <fr.jkrieg@greekwelfaresa.org.au>

kriegfrj added a commit to kriegfrj/bnd that referenced this issue


          [core] Made Central a service

fba34f7

Part of bndtools#5004

Signed-off-by: Fr Jeremy Krieg <fr.jkrieg@greekwelfaresa.org.au>

kriegfrj added a commit to kriegfrj/bnd that referenced this issue


          [builder] Change BndtoolsBuilder to facade pattern

0a6f7f9

Fixes bndtools#5004

Signed-off-by: Fr Jeremy Krieg <fr.jkrieg@greekwelfaresa.org.au>

kriegfrj added a commit to kriegfrj/bnd that referenced this issue


          [validators] Change validators to use services

c16a0df

Partially fixes bndtools#5005, bndtools#5004.

Signed-off-by: Fr Jeremy Krieg <fr.jkrieg@greekwelfaresa.org.au>

bjhargrave modified the milestones: 6.3, 6.4

bjhargrave modified the milestones: 6.4, 7.0

Member

pkriens commented Feb 28, 2023

@kriegfrj I am not sure how this can be done? Creating the facade is easy but BndtoolsBuilder is connected with the project. So if the service goes, you need to save the state and restore it?

I like the idea but I would like to close this issue, it is has been outstanding for a long time. I can move it to abeyance if you want.

Contributor Author

kriegfrj commented Feb 28, 2023

Sorry, feel free to move to abeyance. By now the PR probably had a few cobwebs that need cleaning out and I don't have time right now, sorry. But i recall it was nearly working.

Member

pkriens commented Mar 1, 2023

Ok, I am moving it to abeyance for now. It looks very interesting though, would be great if you could finish it one day.

pkriens added the abeyance label

pkriens closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment