Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Eclipse Bug] JVM Crash #5062

Closed
amitjoy opened this issue Jan 17, 2022 · 1 comment · Fixed by #5411
Closed

[Eclipse Bug] JVM Crash #5062

amitjoy opened this issue Jan 17, 2022 · 1 comment · Fixed by #5411
Assignees
@pkriens @juergen-albert
Milestone
6.4

Comments

@amitjoy
Copy link
Member

amitjoy commented Jan 17, 2022

Reappearance of #4854

Tested Version:

  • Latest Snapshot
  • Eclipse 2021-12
@bjhargrave bjhargrave added this to the 6.3 milestone Mar 4, 2022
@bjhargrave bjhargrave modified the milestones: 6.3, 6.4 Apr 29, 2022
pkriens added a commit to pkriens/bnd that referenced this issue May 9, 2022
@pkriens
bndtools#5062 JVM crash
e0ac1e2 
Another desperate attempt to fix the JVM crash
in the bndtools explorer. 

This fix coalesces some update events by waiting 
10 ms before starting to do the UI work.

This should reduce the rate at which we call SWT 
and this _might_ solve this stupid SWT bug

Signed-off-by: Peter Kriens <Peter.Kriens@aqute.biz>
pkriens added a commit to pkriens/bnd that referenced this issue May 9, 2022
@pkriens
bndtools#5062 JVM crash
fdbd861 
Another desperate attempt to fix the JVM crash
in the bndtools explorer. 

This fix coalesces some update events by waiting 
10 ms before starting to do the UI work.

This should reduce the rate at which we call SWT 
and this _might_ solve this stupid SWT bug


Signed-off-by: Peter Kriens <Peter.Kriens@aqute.biz>
pkriens added a commit that referenced this issue May 9, 2022
@pkriens
Merge pull request #5244 from pkriens/master
4f96bc4 
#5062 JVM crash
bjhargrave pushed a commit to bjhargrave/bnd that referenced this issue May 19, 2022
@pkriens @bjhargrave
bndtools#5062 JVM crash
ea24b46 
Another desperate attempt to fix the JVM crash
in the bndtools explorer. 

This fix coalesces some update events by waiting 
10 ms before starting to do the UI work.

This should reduce the rate at which we call SWT 
and this _might_ solve this stupid SWT bug


Signed-off-by: Peter Kriens <Peter.Kriens@aqute.biz>
Signed-off-by: BJ Hargrave <bj@hargrave.dev>
@ViToni
Copy link

ViToni commented Sep 16, 2022

Also valid for Eclipse 2022-09 and bnd 6.3.1.
(Somehow expected since https://bugs.eclipse.org/bugs/show_bug.cgi?id=576099 doesn't have any progress on that matter.)

pkriens added a commit to pkriens/bnd that referenced this issue Nov 3, 2022
@pkriens
bndtools#5062 JVM Crash in bndtools explorer
09794da 
I was able to consistently crash the VM by
selecting a binary class file in rt.jar from
the VM project item and then closing the VM project
item.

After hundreds of trials I found that the bug was
triggered when the getTreeViewer().refresh() was
called during a model update. For the record,
this happened on the main thread so I cannot
see any issue with this.

I then made the refresh conditional on a change
in the filter text field. For this, an
AtomicBoolean dirtyFilter was added.

This seemed to work fine now.

Of course this does not remove the bug. There
is an SWT bug lurking but closing an tree item
in the bnd explorer will no longer trigger it.



Signed-off-by: Peter Kriens <Peter.Kriens@aqute.biz>
pkriens added a commit to pkriens/bnd that referenced this issue Nov 3, 2022
@pkriens
bndtools#5062 JVM Crash in bndtools explorer
9158037 
I was able to consistently crash the VM by
selecting a binary class file in rt.jar from
the VM project item and then closing the VM project
item.

After hundreds of trials I found that the bug was
triggered when the getTreeViewer().refresh() was
called during a model update. For the record,
this happened on the main thread so I cannot
see any issue with this.

I then made the refresh conditional on a change
in the filter text field. For this, an
AtomicBoolean dirtyFilter was added.

This seemed to work fine now.

Of course this does not remove the bug. There
is an SWT bug lurking but closing an tree item
in the bnd explorer will no longer trigger it.



Signed-off-by: Peter Kriens <Peter.Kriens@aqute.biz>
@pkriens pkriens mentioned this issue Nov 3, 2022
Merged
pkriens added a commit that referenced this issue Nov 3, 2022
@pkriens
Merge pull request #5411 from pkriens/master
14fe674 
#5062 JVM Crash in bndtools explorer
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pkriens pkriens

@juergen-albert juergen-albert

Labels
None yet
Projects
None yet
Milestone
6.4
Development

Successfully merging a pull request may close this issue.

#5062 JVM Crash in bndtools explorer pkriens/bnd
5 participants
@pkriens @bjhargrave @juergen-albert @ViToni @amitjoy