Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Built-in workspace templates inconsistent between OSGi R7 and OSGi R8 #5955

Open
scottslewis opened this issue Dec 31, 2023 · 2 comments
Open
Assignees

Comments

@scottslewis
Copy link
Contributor

This file org.bndtools.templating.gitrepo/resources/processed/org/bndtools/templating/jgit/initialrepos.txt specifies the two workspace templates made available by default in bnd workspace creation.

Currently (and historically) it has these two workspace templates defined in the repos with same name

bndtools/workspace - https://github.com/bndtools/workspace
bndtools/bndtools.workspace.min = https://github.com/bndtools/bndtools.workspace.min

As per this issue: bndtools/bndtools.workspace.min#7 bndtools.workspace.min has been updated to OSGi R8 on master branch and initialrepos.txt now points to it.

In initialRepos.txt, however, bndtools.workspace still refers to OSGi 7.1, not 8. There is an open pull request in bndtools.workspace repo to move to R8: bndtools/workspace#24.

Either bndtools.workspace pr bndtools/workspace#24 should be merged to main and initialrepos.txt updated to use main branch OR there was some discussion to remove bndtools.workspace from initialrepos.txt (and wizard code I think?). In any case, if both repos in initialrepos.txt remain then both should be on R8 OR there should only be bndtools.workspace.min (on R8 already)

@pkriens @chrisrueger

@pkriens
Copy link
Member

pkriens commented Feb 16, 2024

@scottslewis can we have a call about this? We're discussing this and I think it makes sense to ONLY have min. We can then add other repos via bnd files in the ext directory.

Contact me via email so we can setup a zoom call.

@scottslewis
Copy link
Contributor Author

@pkriens I'm sorry, but I've got family and work commitments this week that will make a call impossible.

To state my opinion: I have no problems with having only one template (min/R8). However, all of my tooling experience tells me that whenever anything is removed, it will likely cause at least some confusion and churn in the user community. I'm not sure how to prevent this churn, but I do think it's worthy of a) some communication with the community to assess how many problems this might cause/warn them, and for whom and/or b) some technical effort to reduce (or make more gradual) the churn.

@pkriens pkriens self-assigned this Mar 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants