Skip to content
This repository has been archived by the owner on Dec 9, 2018. It is now read-only.

Make sections in Resolution Results dialog resize when collapsed #1611 #1645

Closed
wants to merge 1 commit into from

Conversation

wodencafe
Copy link
Contributor

This makes the uncollapsed sections in Resolution Results Dialog resize when one of them is collapsed.

This fixes #1611.

Signed-off-by: Chris Boyd wodencafe@gmail.com

GridLayout layout = new GridLayout(1, false);
composite.setLayout(layout);

SashForm form = new SashForm(composite, SWT.VERTICAL);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can't remove the sash form, this is what gives users ability to grab the border between the sections and manually expand/contract them. So can you reintroduce the sash form into the hierarchy?


GridLayout layout = new GridLayout(1, true);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This layout object doesn't get used.

@gamerson
Copy link
Contributor

Hey @wodencafe we were pretty close here, just checking to see if you were able to make the updates.

@wodencafe
Copy link
Contributor Author

Hi @gamerson, I have been trying to get the sections to both auto size the others when collapsed, and still be draggable sash forms. SWT is not cooperating, it will either be draggable or auto-size capable, but not both.

Do you know of anywhere in eclipse that has done this correctly, that I can look at and see what I'm doing differently?

@gamerson
Copy link
Contributor

@wodencafe can you send me what you have and I can take a look? We may have to regroup here.

@gamerson
Copy link
Contributor

gamerson commented May 1, 2017

@wodencafe ping :)

@bjhargrave bjhargrave added this to the Someday milestone May 26, 2017
@bjhargrave
Copy link
Member

Closing. Please open a new PR if you are able to address the comments raised.

@bjhargrave bjhargrave closed this Mar 16, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Collapsible sections in Resolution Results dialog don't work
3 participants