Skip to content
This repository has been archived by the owner on Dec 9, 2018. It is now read-only.

I/O error reading JAR file contents in Jar Editor #1636

Open
rherrmann opened this issue Jan 24, 2017 · 4 comments
Open

I/O error reading JAR file contents in Jar Editor #1636

rherrmann opened this issue Jan 24, 2017 · 4 comments
Milestone

Comments

@rherrmann
Copy link
Contributor

rherrmann commented Jan 24, 2017

My Bndtools workspace got stuck in an endless Building workspace loop (will try to isolate this and report separately). Before that happened, I opened a Jar editor on a jar file generated by bnd. Now, upon every workspace build cycle, the Jar editor shows an error dialog and writes the below stack trace to the error log.

java.io.FileNotFoundException: C:\Users\Ruediger\git\bndtools\bndtools.m2e\generated\bndtools.m2e.jar (The system cannot find the file specified)
	at java.util.zip.ZipFile.open(Native Method)
	at java.util.zip.ZipFile.<init>(Unknown Source)
	at java.util.zip.ZipFile.<init>(Unknown Source)
	at java.util.zip.ZipFile.<init>(Unknown Source)
	at bndtools.jareditor.internal.JAREntryPart$4.run(JAREntryPart.java:189)
	at org.eclipse.core.internal.jobs.Worker.run(Worker.java:55)
@bjhargrave
Copy link
Member

Seems like the JAR editor is working as expected on an invalid jar.

Why the jar is invalid is a separate issue.

@rherrmann
Copy link
Contributor Author

I disagree that an editor which shows unsolicited (error) message and gets in the users way is working as expected.

Take the text editor, for example, that doesn't refresh its contents just because the underlying file was changed outside the workspace. And if the Jar editor is really meant to refresh its content without the users desire, it should do so in a nonobstructive way, e.g. by using its content area to signal that underlying file is gone.

@bjhargrave
Copy link
Member

If you open the JAR editor on an invalid jar file, what would you expect the editor to do besides display some message.

Perhaps your description of the issue was not sufficient to understand your meaning.

@rherrmann
Copy link
Contributor Author

At the time I opened the JAR editor, the file did exist and was valid and the editor showed its contents just fine. After that, I did something that triggered the endless build loop and the editor showed the above-described behavior.

Does that clarify the circumstances?

@bjhargrave bjhargrave reopened this Feb 17, 2017
@bjhargrave bjhargrave added this to the Someday milestone Feb 17, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants