From 1681c365a9d2e147056cb75c46a28e2f7cf73eac Mon Sep 17 00:00:00 2001 From: Ben Noordhuis Date: Thu, 25 May 2023 16:22:14 +0200 Subject: [PATCH] tools: don't gitignore base64 config.h The file is checked into git. Ignoring it causes a very non-obvious way of breaking tarball builds: 1. Download and unpack tarball 2. Check the sources into git with `git init; git add .; git commit -a` 3. Clean the source tree with `git clean -dfx` 4. Run `./configure && make` 5. Observe build failure because config.h is missing Fixes: https://github.com/nodejs/node/issues/47638 --- tools/dep_updaters/update-base64.sh | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/tools/dep_updaters/update-base64.sh b/tools/dep_updaters/update-base64.sh index b0d8693f82f1b7..5d10a205f881c2 100755 --- a/tools/dep_updaters/update-base64.sh +++ b/tools/dep_updaters/update-base64.sh @@ -51,6 +51,10 @@ mv "$WORKSPACE/base64" "$DEPS_DIR/base64/" # to work, we create it and leave it empty. echo "// Intentionally empty" >> "$DEPS_DIR/base64/base64/lib/config.h" +# Clear out .gitconfig, otherwise config.h is ignored. That's dangerous when +# people check in our tarballs into source control and run `git clean`. +echo "# Intentionally empty" >> "$DEPS_DIR/base64/base64/.gitconfig" + echo "All done!" echo "" echo "Please git add base64/base64, commit the new version:"