From ee875f9d0556471291025702020fe3ac77406861 Mon Sep 17 00:00:00 2001 From: Ben Noordhuis Date: Tue, 20 Mar 2018 21:08:55 +0100 Subject: [PATCH] build: build with -D_FILE_OFFSET_BITS=64 again Faulty logic in commit fdf7c2a ("build: split off tests into separate gyp file") accidentally disabled `-D_FILE_OFFSET_BITS=64` on Unices, breaking file operations on files > 2 GB on 32 bits platforms. Fixes: https://github.com/nodejs/node/issues/19455 PR-URL: https://github.com/libuv/libuv/pull/1779 Reviewed-By: Colin Ihrig Reviewed-By: Santiago Gimeno --- uv.gyp | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/uv.gyp b/uv.gyp index a5046b87ea5..0f11f0622be 100644 --- a/uv.gyp +++ b/uv.gyp @@ -2,12 +2,12 @@ 'variables': { 'conditions': [ ['OS=="win"', { + 'shared_unix_defines': [ ], + }, { 'shared_unix_defines': [ '_LARGEFILE_SOURCE', '_FILE_OFFSET_BITS=64', ], - }, { - 'shared_unix_defines': [ ], }], ['OS in "mac ios"', { 'shared_mac_defines': [ '_DARWIN_USE_64_BIT_INODE=1' ],