Ugly assertion diagrams

[bnorm]

Have an ugly diagramed assertion? Share it here and let's make it better!

[christophsturm]

in this assertion error its really hard to see what value is wrong

java.lang.AssertionError: Assertion failed
assert(
    contextResult is FailedContext && (
    |
    true
    FailedContext(context=Context(name=unknown, parent=null, sourceInfo=null, isolation=true), failure=failgood.ErrorLoadingContextsFromClass: the error)
        contextResult.failure.message == "the error" &&
        |             |       |       |
        |             |       |       true
        |             |       the error
        |             failgood.ErrorLoadingContextsFromClass: the error
        FailedContext(context=Context(name=unknown, parent=null, sourceInfo=null, isolation=true), failure=failgood.ErrorLoadingContextsFromClass: the error)
        FailedContext(context=Context(name=unknown, parent=null, sourceInfo=null, isolation=true), failure=failgood.ErrorLoadingContextsFromClass: the error)
            contextResult.context.name == MyErrorTest::class.java.name
            |             |       |    |  |                  |    |
            |             |       |    |  |                  |    failgood.SuiteTest$context$1$4$1$MyErrorTest
            |             |       |    |  |                  class failgood.SuiteTest$context$1$4$1$MyErrorTest
            |             |       |    |  class failgood.SuiteTest$context$1$4$1$MyErrorTest
            |             |       |    false
            |             |       unknown
            |             Context(name=unknown, parent=null, sourceInfo=null, isolation=true)
            FailedContext(context=Context(name=unknown, parent=null, sourceInfo=null, isolation=true), failure=failgood.ErrorLoadingContextsFromClass: the error)
            FailedContext(context=Context(name=unknown, parent=null, sourceInfo=null, isolation=true), failure=failgood.ErrorLoadingContextsFromClass: the error)
        )
)

i made a branch that creates that exception error:
https://github.com/failgood/failgood/tree/power-assert-failure just run SuiteTest or all tests. from idea or gradle.

[bnorm]

I see a few things which can be improved but I'm curious to know what you think the diagram should be. Here's how I think it should look:

java.lang.AssertionError: Assertion failed
assert(
    contextResult is FailedContext && (
    |             |
    |             true
    FailedContext(context=Context(name=unknown, parent=null, sourceInfo=null, isolation=true), failure=failgood.ErrorLoadingContextsFromClass: the error)
        contextResult.failure.message == "the error" &&
        |             |       |       |
        |             |       |       true
        |             |       the error
        |             failgood.ErrorLoadingContextsFromClass: the error
        FailedContext(context=Context(name=unknown, parent=null, sourceInfo=null, isolation=true), failure=failgood.ErrorLoadingContextsFromClass: the error)
            contextResult.context.name == MyErrorTest::class.java.name
            |             |       |    |  |                  |    |
            |             |       |    |  |                  |    failgood.SuiteTest$context$1$4$1$MyErrorTest
            |             |       |    |  |                  class failgood.SuiteTest$context$1$4$1$MyErrorTest
            |             |       |    |  class failgood.SuiteTest$context$1$4$1$MyErrorTest
            |             |       |    false
            |             |       unknown
            |             Context(name=unknown, parent=null, sourceInfo=null, isolation=true)
            FailedContext(context=Context(name=unknown, parent=null, sourceInfo=null, isolation=true), failure=failgood.ErrorLoadingContextsFromClass: the error)
        )
)

Specific things I see which can be improved:

• Proper alignment of is result.
• Smart cast might be causing the duplicate contextResult output. Can probably ignore smart cast results.

[christophsturm]

I think that for complex asserts like this one it would be good if the false that leads to the assertion failing could be marked somehow.

maybe something simple like

java.lang.AssertionError: Assertion failed
assert(
    contextResult is FailedContext && (
    |             |
    |             true
    FailedContext(context=Context(name=unknown, parent=null, sourceInfo=null, isolation=true), failure=failgood.ErrorLoadingContextsFromClass: the error)
        contextResult.failure.message == "the error" &&
        |             |       |       |
        |             |       |       true
        |             |       the error
        |             failgood.ErrorLoadingContextsFromClass: the error
        FailedContext(context=Context(name=unknown, parent=null, sourceInfo=null, isolation=true), failure=failgood.ErrorLoadingContextsFromClass: the error)
            contextResult.context.name == MyErrorTest::class.java.name
            |             |       |    |  |                  |    |
            |             |       |    |  |                  |    failgood.SuiteTest$context$1$4$1$MyErrorTest
            |             |       |    |  |                  class failgood.SuiteTest$context$1$4$1$MyErrorTest
            |             |       |    |  class failgood.SuiteTest$context$1$4$1$MyErrorTest
            |             |       | ***false***
            |             |       unknown
            |             Context(name=unknown, parent=null, sourceInfo=null, isolation=true)
            FailedContext(context=Context(name=unknown, parent=null, sourceInfo=null, isolation=true), failure=failgood.ErrorLoadingContextsFromClass: the error)
        )

I'm still new to writing assertions this way, but I try to put anything that could be interesting in seeing why the assertion failed into one assert , to have one error message that shows me what went wrong and why, but maybe the solution is to stick to simpler asserts and use soft asserts.
Also maybe not every part of the == MyErrorTest::class.java.name is really interesting and should be graphed, but i have no real idea how to easily decide whats interesting and whats not. (in this example MyErrorTest::class is basically the same as MyErrorTest::class.java.