Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cargo install critcmp installs if install is cached by CI runner #104

Open
juntyr opened this issue Aug 21, 2023 · 0 comments · May be fixed by #105
Open

cargo install critcmp installs if install is cached by CI runner #104

juntyr opened this issue Aug 21, 2023 · 0 comments · May be fixed by #105

Comments

@juntyr
Copy link

juntyr commented Aug 21, 2023

Perhaps the action could first check if cargo critcmp exists and only if that fails run the installation? Thanks for your help!

Here's the error log:

2023-08-21T03:31:39.5650135Z ##[group]Run boa-dev/criterion-compare-action@v3
2023-08-21T03:31:39.5650424Z with:
2023-08-21T03:31:39.5651056Z   branchName: master
2023-08-21T03:31:39.5651854Z   token: ***
2023-08-21T03:31:39.5651960Z   defaultFeatures: true
2023-08-21T03:31:39.5652052Z ##[endgroup]
2023-08-21T03:31:39.6729665Z [command]/home/runner/.cargo/bin/cargo install critcmp
2023-08-21T03:31:39.7747230Z     Updating crates.io index
2023-08-21T03:31:39.9570372Z error: binary `critcmp` already exists in destination
2023-08-21T03:31:39.9570853Z Add --force to overwrite
2023-08-21T03:31:39.9589680Z Error: The process '/home/runner/.cargo/bin/cargo' failed with exit code 101
2023-08-21T03:31:39.9590262Z     at ExecState._setResult (/home/runner/work/_actions/boa-dev/criterion-compare-action/v3/dist/index.js:1:24691)
2023-08-21T03:31:39.9590917Z     at ExecState.CheckComplete (/home/runner/work/_actions/boa-dev/criterion-compare-action/v3/dist/index.js:1:24251)
2023-08-21T03:31:39.9592134Z     at ChildProcess.<anonymous> (/home/runner/work/_actions/boa-dev/criterion-compare-action/v3/dist/index.js:1:23092)
2023-08-21T03:31:39.9592652Z     at ChildProcess.emit (node:events:513:28)
2023-08-21T03:31:39.9592929Z     at maybeClose (node:internal/child_process:1100:16)
2023-08-21T03:31:39.9593253Z     at Process.ChildProcess._handle.onexit (node:internal/child_process:304:5)
2023-08-21T03:31:39.9616420Z ##[error]Unhanded error:
Error: The process '/home/runner/.cargo/bin/cargo' failed with exit code 101
@juntyr juntyr linked a pull request Aug 21, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant