Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

We don't allow benchmarking only one package #5

Closed
Razican opened this issue Jun 10, 2020 · 2 comments
Closed

We don't allow benchmarking only one package #5

Razican opened this issue Jun 10, 2020 · 2 comments
Labels
enhancement New feature or request

Comments

@Razican
Copy link
Member

Razican commented Jun 10, 2020

In this commit, we removed the -p Boa from the command. This makes it portable for other things, but it removes the posibility to benchmark a certain package in a workspace.

This is causing all boa builds to fail. We should include an optional "package" parameter in the action configuration, and add it to the command line arguments.
@Razican Razican added bug Something isn't working enhancement New feature or request and removed bug Something isn't working labels Jun 10, 2020
@Razican
Copy link
Member Author

Razican commented Jun 10, 2020

This has been solved by cwd, but we should probably still allow using the -p benchmarking option.

@HalidOdat HalidOdat pinned this issue Jun 12, 2020
@HalidOdat
Copy link
Member

HalidOdat commented Mar 15, 2023 •
edited

Should be fixed by #91

@Razican Razican closed this as completed Mar 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Razican @HalidOdat