Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not working on GitHub enterprise #62

Open
lcmgh opened this issue May 23, 2022 · 6 comments
Open

Not working on GitHub enterprise #62

lcmgh opened this issue May 23, 2022 · 6 comments

Comments

@lcmgh
Copy link

lcmgh commented May 23, 2022

(Use node --trace-deprecation ... to show where the warning was created)
Warning: Failed to comment: HttpError: request to https://mycompany/api/v3/repos/myorg/myrepo/issues/9/comments failed, reason: tunneling socket could not be established, statusCode=503
Commenting is not possible from forks.
┌─────────┬────────────────────────────┬─

- uses: boa-dev/criterion-compare-action@6fdd4e866a4d4539e126afc158249a7631cc842e
  with:
    benchName: "my_benchmark"
    # Needed. The name of the branch to compare with. This default uses the branch which is being pulled against
    branchName: ${{ github.base_ref }}
    # Optional. Default is `${{ github.token }}`.
    token: ${{ secrets.GITHUB_TOKEN }}
@Razican
Copy link
Member

Razican commented May 29, 2022

Which version of GitHub Enterprise is this? We now use Node 16, which might not be available in all GitHub Enterprise versions.

@lcmgh
Copy link
Author

lcmgh commented Jul 7, 2022

The benchmark itself run through fine. What I am getting in the end is:

Warning: Failed to comment: HttpError: request to https://my-enterprise.com/api/v3/repos/myorg/my-service/issues//comments failed, reason: tunneling socket could not be established, statusCode=503
Commenting is not possible from forks.

GitHub Enterprise Server 3.4.3

@Razican
Copy link
Member

Razican commented Jul 7, 2022

The benchmark itself run through fine. What I am getting in the end is:


Warning: Failed to comment: HttpError: request to https://my-enterprise.com/api/v3/repos/myorg/my-service/issues//comments failed, reason: tunneling socket could not be established, statusCode=503

Commenting is not possible from forks.

GitHub Enterprise Server 3.4.3

Hmm is the PR coming from a fork, instead of a branch in the same repo?

@lcmgh
Copy link
Author

lcmgh commented Jul 8, 2022

The log from the previous comment came indeed from a branch triggered build and not from a PR, sorry for that.

I have now triggered the action from a pull request and it says

(node:745370) [DEP0005] DeprecationWarning: Buffer() is deprecated due to security and usability issues. Please use the Buffer.alloc(), Buffer.allocUnsafe(), or Buffer.from() methods instead.
(Use `node --trace-deprecation ...` to show where the warning was created)
Warning: Failed to comment: HttpError: request to https://my-company.com/api/v3/repos/myorg/myproject/issues/15/comments failed, reason: tunneling socket could not be established, statusCode=503
Commenting is not possible from forks.
┌─────────┬────────────────────────────

The URL of my PR is https://my-company.com/myorg/myproject/pull/15

The runner has appropriate proxy settings (HTTP_PROXY, HTTPS_PROXY, NO_PROXY) in place to use a proxy for intranet-internet connections and none for internal connections (such as the GitHub enterprise it is connected to).

@Razican
Copy link
Member

Razican commented Jul 9, 2022

Note that GitHub doesn't allow writing comments from forks. This is a known limitation in GitHub, and there is nothing that can be done about it, unfortunately :(

@lcmgh
Copy link
Author

lcmgh commented Jul 11, 2022

Actually the PR comes from the same repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants