Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added the "behaviour" parameter #81

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Added the "behaviour" parameter #81

wants to merge 2 commits into from

Conversation

Razican
Copy link
Member

@Razican Razican commented Oct 23, 2022

This is the first change towards v4, which ideally should include #8, #80 and only showing "changing" benchmarks by default.

This fixes #8, but it has not been thoroughly tested, so I would like to test this in Boa before merging.

@finnbear
Copy link

Thanks for implementing these changes! A minor suggestion is to move the listComments query inside the try { } block. Otherwise, its failure (due to an HTTP/permissions error) causes the fallback table to not be printed.

@chenyan2002
Copy link

Any update on this PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature Request] Update the benchmark comment, don't create a new one
3 participants
@Razican @finnbear @chenyan2002