Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use proc_macro's Diagnostic api if building with nightly compiler #5

Open
dtolnay opened this issue Nov 19, 2018 · 0 comments
Open

Use proc_macro's Diagnostic api if building with nightly compiler #5

dtolnay opened this issue Nov 19, 2018 · 0 comments

Comments

@dtolnay
Copy link
Contributor

dtolnay commented Nov 19, 2018

The typed-html/macros/build.rs already performs version detection to enable some alternative codepaths on nightly. Let's also make use of proc_macro::Diagnostic::spanned on nightly, which makes it possible to use Diagnostic::note and Diagnostic::help to make some of the output clearer -- #1 (comment).

https://doc.rust-lang.org/nightly/proc_macro/struct.Diagnostic.html
@dtolnay dtolnay mentioned this issue Nov 19, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@dtolnay