Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support a doubleClick on handleComponent to give the component full width #753

Open
axvargas opened this issue Nov 6, 2021 · 4 comments

Comments

@axvargas
Copy link

axvargas commented Nov 6, 2021

I would like you, if it's possible, to add a DoubleClick action to the handleComponent in order to give the component full width or to a certain size in case of doubeClick

@MurrayJack
Copy link

I would also really like this

@rfgamaral
Copy link

Came here requesting such a feature. Glad to see I'm not alone in needing this functionality, sadden to see that this library seems to be abandoned... 😞

@alne4294
Copy link

alne4294 commented Mar 8, 2022

I believe that this is actually a regression.

We were able to support this on version 4.2.1 by adding a onDoubleClick={somefunc} to the div that was rendered by the custom component specified on the handleComponent property.

I was able to narrow down a breakage on this behavior though somewhere between 4.3.1 and 4.3.2.

From looking at the changelog/git history, this would make me think that one of these two commits are the breaking change, but I don't really see how from looking at the code:

@thien-do
Copy link

Also onMouseMove still work, but not onClick or onDoubleClick. Maybe there is an event.preventDefault somewhere in mouseDown or a new element on top and prevent it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants