Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix deprecated componentWillRecieveProps lifecycle method usage #504

Closed
nerrad opened this issue Aug 7, 2019 · 2 comments
Closed

Fix deprecated componentWillRecieveProps lifecycle method usage #504

nerrad opened this issue Aug 7, 2019 · 2 comments

Comments

@nerrad
Copy link

nerrad commented Aug 7, 2019

Overview of the problem

I'm using re-resizable version [5.0.1]. As implemented in the WordPress Gutenberg Project in the @wordpress/components package.

My browser is: Chrome

I am sure this issue is not a duplicate? Yes

Description

The componentWillReceiveProps lifecycle method is deprecated in React and beginning in React 17 will stop working. React in strict mode will show a warning for its usage. re-resizable implements this lifecycle method here:

re-resizable/src/index.tsx

Lines 463 to 465 in 7ea1544

public componentWillReceiveProps(next: ResizableProps) {
this.updateExtendsProps(next);
}

@bokuweb
Copy link
Owner

bokuweb commented Aug 12, 2019

@nerrad Please try v6.0.0 :)

@nerrad
Copy link
Author

nerrad commented Aug 13, 2019

Confirmed fixed. Thanks for the quick turnaround - much appreciated :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants