Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor passing of flags to require less hacks #223

Open
lukebatchelor opened this issue Apr 15, 2019 · 0 comments
Open

Refactor passing of flags to require less hacks #223

lukebatchelor opened this issue Apr 15, 2019 · 0 comments

Comments

@lukebatchelor
Copy link
Member

As a part of #214 we had to skip some tests that were technically never actually testing anything. To get them passing would require some pretty gross hacking of process.argv within tests that I'm not super comfortable leaving in.

I think the correct path forward is to refactor how we pass args to our scripts. Maybe as simple as passing an untyped raw copy of the args along with the typed ones as an escape hatch.

By passing it it, we wont require the hacks in #214 of using the process.argv and wont require any hacks to get the tests working (as we can pass whatever we need to in those mocked calls).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant