Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug(Yarn): replaced relative path to bin with npx and first argument #253

Open
6 tasks done
Stradivario opened this issue Oct 2, 2019 · 1 comment
Open
6 tasks done

Comments

@Stradivario
Copy link

Stradivario commented Oct 2, 2019

Title Description
Version 0.24.2
Type Issue
node 10.16.0
Operating System Ubuntu 18.04 LTS
Short Description ENOENT yarn when yarn not present inside bold/node_modules/.bin since there are conditions like inside Runners where .bin path is not linked properly.
Detailed description This issue present when we use Codeship Build process. Codeship environment has different way of linking, mapping, caching installed packages so it is not a good option to think that we will have yarn installed and linked for us. This pull request introduces simple fix using npx command.

Type of change

  • Non Breaking change

Checklist:

  • Replace relative path of yarn with npx command
  • Put yarn command inside first argument of execution inside child process
  • Fix Tests to fit new flow when using yarn with npx
  • Expected arguments inside yarn.test.js are now 2 instead of 1
  • Removed project-bin-path from dependencies since npx is more powerful
/home/rof/.nvm/versions/node/v10.16.0/bin/yarnpkg -> /home/rof/.nvm/versions/node/v10.16.0/lib/node_modules/yarn/bin/yarn.js
/home/rof/.nvm/versions/node/v10.16.0/lib
└── yarn@1.19.0 

⚡️   bolt v0.24.2 (node v10.16.0)
🔎   [1/4] Validating project...
📦   [2/4] Installing project dependencies...
error Error: spawn /home/rof/src/github.com/camplight/consento/node_modules/bolt/node_modules/.bin/yarn ENOENT
@Stradivario
Copy link
Author

Stradivario commented Oct 2, 2019

Pull request introduced with fix

#254

In the meanwhile till it is merged you can use replacement npx @rxdi/bolt

npm i -g @rxdi/bolt

Use bolt command as usual

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant