New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add namespace context for Saxon compatibility #503
Conversation
Codecov Report
@@ Coverage Diff @@
## master #503 +/- ##
============================================
- Coverage 73.35% 73.19% -0.17%
- Complexity 580 587 +7
============================================
Files 28 28
Lines 2004 1992 -12
Branches 245 244 -1
============================================
- Hits 1470 1458 -12
- Misses 409 415 +6
+ Partials 125 119 -6
Continue to review full report at Codecov.
|
I never saw this problem happening. How can it be reproduced? |
In order to have this issue the Webdriver Manager has to be used in project with Saxon which by default respects xml namespaces. |
@andreikondratev I tried to reproduce this issue but I cannot. I created a new project using Selenium WebDriver and WebDriverManager, available here: https://github.com/bonigarcia/webdrivermanager-basic Then, I added the Saxon dependency to the project, but the tests are still running nicely:
Any clue about how to reproduce the issue with this setup? |
Hi! Can this be a difference of Saxon-HE and Saxon-PE? Let me try this project with Saxon-PE. |
Can confirm this issue occuring with this saxon dependency:
|
@xlemmingx Yes, I tried to reproduce the error with that version of Saxon-HE, thank you. Thanks a lot to everyone for contributing. I am merging this PR. |
Sorry I didn't help to test the quickstart. School holidays knocked me out. |
A fix for #486
Purpose of changes
The WebdriverManager has recently stopped working with Saxon. This change adds namespace context to make it work with Saxon xPath factory.
Types of changes
How has this been tested?
I created a custom build for our test suite to make it work. It works in our teamcity.