Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WDM doesn't work without docker-java depedency #691

Closed
asolntsev opened this issue Sep 3, 2021 · 3 comments
Closed

WDM doesn't work without docker-java depedency #691

asolntsev opened this issue Sep 3, 2021 · 3 comments

Comments

@asolntsev
Copy link
Contributor

Description of the problem:
I want to exclude docker-* all dependencies because I never run browser in Docker:

  api('io.github.bonigarcia:webdrivermanager:5.0.1') {
    exclude group: 'org.apache.httpcomponents.core5'
    exclude group: 'com.github.docker-java', module: 'docker-java'
    exclude group: 'org.rauschig'
  }

But I am receiving errors - despite the fact I don't use Docker.
I think class io.github.bonigarcia.wdm.WebDriverManager should postpone initialisation of field dockerService until it's really needed.

WebDriverManager version: 5.0.1

WebDriverManager call: WebDriverManager.chromedriver().setup();

Error log:

java.lang.NoClassDefFoundError: com/github/dockerjava/core/DockerClientConfig
	at io.github.bonigarcia.wdm.WebDriverManager.<init>(WebDriverManager.java:195)
	at io.github.bonigarcia.wdm.managers.ChromeDriverManager.<init>(ChromeDriverManager.java:47)
	at io.github.bonigarcia.wdm.WebDriverManager.chromedriver(WebDriverManager.java:206)
	at com.codeborne.selenide.webdriver.ChromeDriverFactory.setupWebdriverBinary(ChromeDriverFactory.java:44)
@ssurwas
Copy link

ssurwas commented Sep 3, 2021

true

@bonigarcia
Copy link
Owner

@asolntsev Have you tested the PR? Is it working in your project with that change?

@lasnamae
Copy link
Contributor

lasnamae commented Sep 9, 2021 via email

bonigarcia added a commit that referenced this issue Sep 9, 2021
#691 postpone initialisation of DockerService until it's really needed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants