Skip to content
This repository has been archived by the owner on Sep 7, 2021. It is now read-only.

Question about project choices #29

Open
LeonardoGentile opened this issue Nov 30, 2016 · 0 comments
Open

Question about project choices #29

LeonardoGentile opened this issue Nov 30, 2016 · 0 comments

Comments

@LeonardoGentile
Copy link

Hello,
thank you for this project, well appreciated. I have a couple of question, I am React beginner but I have already created a version of AdminLTE for angular 1 in the past so I know most of its features and settings. I have some question about your choices for this project:

  • The file structure.
    • Under public I guess you replicated the relevant part from admintLte, isn't it?
    • public/libraries I see several versions of the same libraries standard and minified, why? What really used? Why not ask for these via npm?
    • it's not clear what's supposed to go under public/dist
  • The separation between jquery and React.
    It is supposed to be against the react best-practises to mix jQuery and React together but I guess this project still heavily relies on jQuery, isn't it? How are you handling this? Would it be possible to completely de-couple them?
  • How do you handle the responsiveness of the templates? This is supposed to be handled by jQuery , "working" on the body element, do you let AdminLte/jQuery do this?
  • Lastly, you package.json has quite some dependencies, if we install your project via npm are you sure all of these are necessary? Probably most of them should be moved under devDependencies? I might be wrong here..

Thanks

@LeonardoGentile LeonardoGentile changed the title Jquery dependency Question about project choices Nov 30, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant