Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

std::abs used without including header in extended_p_square.hpp #50

Open
jefftrull opened this issue Jun 21, 2021 · 1 comment
Open

Comments

@jefftrull
Copy link

std::abs needs either <cmath> or <cstdlib> but neither is included. This results in a particularly hairy ambiguous overload problem on some old versions of gcc.

It also may be better to use std::fabs, which is intended for this use case

@jefftrull
Copy link
Author

This stackoverflow answer was particularly helpful for me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant