Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistent placement props BDropdown and others #1752

Open
3 tasks done
VividLemon opened this issue Feb 6, 2024 · 6 comments
Open
3 tasks done

Inconsistent placement props BDropdown and others #1752

VividLemon opened this issue Feb 6, 2024 · 6 comments
Labels
enhancement New feature or request

Comments

@VividLemon
Copy link
Member

Clear and concise description of the problem

BDropdown does dropup, dropend, etc. This is quite dumb. A single "location" prop, or position prop should be created instead. Similar, if not the same as, https://vuetifyjs.com/en/api/v-tooltip/#props-location . The goal is to remove these individual position props, and unify them. Then to unify all components to this expected structure

Suggested solution

asdf

Alternative

asdf

Additional context

asdf

Validations

@VividLemon VividLemon added the enhancement New feature or request label Feb 6, 2024
@xvaara
Copy link
Contributor

xvaara commented Feb 7, 2024

Should we just use floating-ui ones?

@VividLemon
Copy link
Member Author

What are the differences between the two types?

@VividLemon
Copy link
Member Author

I also need to catalogue what possibly shares "location" values. Location on a drop down popover is different than bcardimg being "end"

@xvaara
Copy link
Contributor

xvaara commented Feb 8, 2024

@xvaara
Copy link
Contributor

xvaara commented Feb 8, 2024

I kinda would like it to be booleans... Not sure about this but:

// bottom by default. props boolean for left, right and top, and start end.
<BTooltip top end> ... </BTooltip>
<BDropdown left start> ... </BDropdown>
<BPopover start> ... </BPopover>

@VividLemon
Copy link
Member Author

I prefer the simple location prop, as I feel like it's a lot of bloat. Having multiple location items makes the template look weird, and in our code you have to do like 4 or 5 useBooleanish statements. In addition, it also makes it easier to see that these props, top, start, end, etc are all related. I think it would just add a lot more simplicity if they were merged and standard throughout the components.

But speaking of Booleanish, after making the changes to useBooleanish and making it a simple !!, it made me think that allowing strings is kinda silly. We may consider using only booleans instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants