Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update vue-tsc 2.0 #1811

Closed
3 tasks done
VividLemon opened this issue Mar 10, 2024 · 3 comments
Closed
3 tasks done

chore: update vue-tsc 2.0 #1811

VividLemon opened this issue Mar 10, 2024 · 3 comments
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@VividLemon
Copy link
Member

Clear and concise description of the problem

vue-tsc needs to be updated. The following needs to occur:

  1. "type-check": "vue-tsc --build --force", replace the script in bvn to this
  2. Tsconfigs need to be updated:

Merge ours with the following:

{
  "extends": "@vue/tsconfig/tsconfig.dom.json",
  "include": ["env.d.ts", "src/**/*", "src/**/*.vue"],
  "compilerOptions": {
    "composite": true,
    "tsBuildInfoFile": "./node_modules/.tmp/tsconfig.app.tsbuildinfo",

    "baseUrl": ".",
  }
}
{
  "extends": "@tsconfig/node20/tsconfig.json",
  "include": [
    "vite.config.*",
    "vitest.config.*",
    "cypress.config.*",
    "nightwatch.conf.*",
    "playwright.config.*"
  ],
  "compilerOptions": {
    "composite": true,
    "noEmit": true,
    "tsBuildInfoFile": "./node_modules/.tmp/tsconfig.node.tsbuildinfo",

    "module": "ESNext",
    "moduleResolution": "Bundler",
    "types": ["node"]
  }
}
{
  "extends": "./tsconfig.app.json",
  "exclude": [],
  "compilerOptions": {
    "composite": true,
    "tsBuildInfoFile": "./node_modules/.tmp/tsconfig.vitest.tsbuildinfo",

    "lib": [],
    "types": ["node", "jsdom"]
  }
}

Some things are not to be merged. For example, we don't use jsdom.

Once that is done, the build errors need to be fixed.

Suggested solution

n

Alternative

No response

Additional context

pnpm create vue@3 to create a blank template, then merge in some of the structural changes.

Other packages need to be updated as well if they haven't already (playground, etc)

Validations

@VividLemon VividLemon added enhancement New feature or request good first issue Good for newcomers labels Mar 10, 2024
@VividLemon
Copy link
Member Author

If #1810 hasn't been merged yet by the time this is finished, rebase and request to push into that branch. Either #1810 goes out standalone, or this goes with #1810

@sceee
Copy link
Contributor

sceee commented Mar 11, 2024

Just wanted to note here that I experienced errors when updating to vue-tsc v2 in a project using bootstrap-vue-next and created this issue for it in vuejs/language-tools which is not yet resolved as of today:
vuejs/language-tools#4026

@VividLemon
Copy link
Member Author

I'm aware, although, I don't believe that is their issue. I believe it's more of a setup issue. But I may be wrong. V2 has been a bit messy. I expected it to be somewhat simple based on the changelog, but has issues like described which has been unpleasant.

@VividLemon VividLemon self-assigned this Apr 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants