-
-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Vue core issue tracker Vue warns of a type check failure
#1846
Vue core issue tracker Vue warns of a type check failure
#1846
Comments
Start a new pull request in StackBlitz Codeflow. |
@VividLemon - this is the same issue that I noted in my description of #1840, sorry if it got lost in the word salad:
Now that these changes are checked in, these warning are showing up in the playground. I get a number of variations on the following when showing
Oddly, if I copy the Again, I tried inlining the types into |
It's weird. The type is: @VividLemon vuejs/core#10676 |
I've tracked this down to the line in RadioTypes.ts: @VividLemon what do you think? |
This would be a vue bug if true. readonly number[] is the same as ReadonlyArray |
I tried applying theses changes to the two affected classes, and while they working in the vue.js playground they didn't seem to work in the actual code. I have a draft PR with details: #1856 |
@VividLemon do we wait for vue to fix this or? they labeled it p3-minor-bug so I'm not holding my breath for a fix any time soon. |
Likely easier to fix it in Vue than here |
Thanks for 0.17.1, it solved the issue when the value of the BFormRadioGroup is a String. I got the following error when the value is an Integer though:
Is this related to the issue you opened in vuejs/core ? |
Yes, it's the same bug. |
@VividLemon & @xvaara - How would you feel about reverting the use of My reasoning:
Assuming my reasoning is sound, let me know what you'd like different from what I currently have in #1847 and I'll be happy to iterate on that until I get it through. Otherwise, I'm interested in any other thoughts on how to get past these warnings. |
It's not an issue with defineModel. It's also a development warning that I'm not too concerned about. Regardless, I'll look into seeing if I can get someone to review it |
Thanks! I hadn't noticed that there is a candidate fix already. If I want to test this against the cases I'm interested in, do you happen to know how I would do that? Do I have to do a private build of vue? Or is there a way to monkey-patch the sfc compiler? |
It seems to be fixed for dev build on 3.4.24, but production build is still broken. |
Vue warns of a type check failure
This issue doesn't really concern bvn. It's a Vue issue. I'm only keeping it around because it affects our lib |
#1864 seems related. Although not directly. |
It's seems to be fixed in the latest release 3.4.25. I'll test tomorrow and release a new version if it fixes this for us. |
Describe the bug
When using BFormRadioGroup, Vue warns of a type check failure for the v-model. It seems to always expect a Boolean. Check the console logs in the StackBlitz reproduction.
Reproduction
https://stackblitz.com/edit/vue-yqphhw?file=src%2FApp.vue
Used Package Manager
yarn
Validations
The text was updated successfully, but these errors were encountered: