Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fade not working for BModalOrchestrator #1861

Open
6 tasks done
dword-design-honestly opened this issue Apr 22, 2024 · 5 comments
Open
6 tasks done

Fade not working for BModalOrchestrator #1861

dword-design-honestly opened this issue Apr 22, 2024 · 5 comments
Labels
bug Something isn't working

Comments

@dword-design-honestly
Copy link

Describe the bug

Looks like the modals created via BModalOrchestrator don't fade. Or am I missing something? See also the examples in the doc.

Reproduction

https://bootstrap-vue-next.github.io/bootstrap-vue-next/docs/composables/useModalController.html

Used Package Manager

pnpm

Validations

  • Have tested with the latest version. This is still alpha version and sometime things change rapidly.
  • Follow our Code of Conduct
  • Read the Contributing Guide.
  • Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
  • Check that this is a concrete bug. For Q&A, please open a GitHub Discussion instead.
  • The provided reproduction is a minimal reproducible of the bug.
@dword-design-honestly dword-design-honestly added the bug Something isn't working label Apr 22, 2024
@stevemandl
Copy link
Contributor

I noticed hide() is not working with modals created with BModalOrchestrator. I guess this is the same thing, just a different way of saying it.
I started troubleshooting and noticed that BModal state does not show up in vue devtools, even though other components show up just fine.
From what I can tell the show class is never getting removed when hide is called, even though the promise resolves correctly.

@dword-design-honestly
Copy link
Author

I especially mean when the modal is showing up. It's instantly there.

@stevemandl
Copy link
Contributor

@dword-design-honestly OK then this is a separate but probably related issue. I mean hide is not working; it is not possible to make the modal go away. The bug I'm describing is also apparent on the example in the docs you cited. If desired, I will create a separate bug-issue.

@dword-design-honestly
Copy link
Author

Looking forward to this since imho the modal orchestrator is one of the main improvements compared to the old project 😊.

@ckrieger
Copy link

@dword-design-honestly OK then this is a separate but probably related issue. I mean hide is not working; it is not possible to make the modal go away. The bug I'm describing is also apparent on the example in the docs you cited. If desired, I will create a separate bug-issue.

I have the same issue since v0.17.0. On v0.16.6 hiding the modal is working. Might be a good idea to create separate issue for this 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants