From e1f77c90f159a4a07742e5939871b383987a10d2 Mon Sep 17 00:00:00 2001 From: "David W. Gray" Date: Tue, 19 Mar 2024 14:24:14 -0700 Subject: [PATCH 1/4] fix(BFormCheckBoxGroup): remove change & input events to conform to #1696 --- .../src/data/components/ComponentReference.ts | 2 +- .../src/data/components/formCheckbox.data.ts | 46 ------------------- .../docs/src/docs/components/form-checkbox.md | 4 +- .../BFormCheckbox/BFormCheckboxGroup.vue | 11 +---- 4 files changed, 4 insertions(+), 59 deletions(-) diff --git a/apps/docs/src/data/components/ComponentReference.ts b/apps/docs/src/data/components/ComponentReference.ts index 49248d3b8..5f6c07524 100644 --- a/apps/docs/src/data/components/ComponentReference.ts +++ b/apps/docs/src/data/components/ComponentReference.ts @@ -17,7 +17,7 @@ export interface ComponentReference { description?: string }[] slots: { - scope: SlotScopeReference[] + scope?: SlotScopeReference[] name: string description?: string }[] diff --git a/apps/docs/src/data/components/formCheckbox.data.ts b/apps/docs/src/data/components/formCheckbox.data.ts index a459c77e5..163ff948d 100644 --- a/apps/docs/src/data/components/formCheckbox.data.ts +++ b/apps/docs/src/data/components/formCheckbox.data.ts @@ -161,30 +161,6 @@ export default { }, ], }, - { - event: 'input', - description: 'Emitted before the checked value is changed', - args: [ - { - arg: 'checked', - type: 'CheckboxValue | readonly CheckboxValue[]', - description: - 'Value of the checkbox before the event. Value will be an array for grouped checkboxes or a single value for standalone checkboxes.', - }, - ], - }, - { - event: 'change', - description: 'Emitted when the checked value is changed', - args: [ - { - arg: 'checked', - type: 'CheckboxValue | readonly CheckboxValue[]', - description: - 'Value of the checkbox. Value will be an array for grouped checkboxes or a single value for standalone checkboxes.', - }, - ], - }, ], slots: [ { @@ -345,28 +321,6 @@ export default { }, ], }, - { - event: 'input', - description: 'Emitted before the selected value(s) are changed', - args: [ - { - arg: 'input', - type: 'CheckboxValue[]', - description: 'Value of the checkboxes before the event. Value will be an array.', - }, - ], - }, - { - event: 'change', - description: 'Emitted when the selected value(s) are changed', - args: [ - { - arg: 'change', - type: 'CheckboxValue[]', - description: 'Value of the checkboxes. Value will be an array.', - }, - ], - }, ], slots: [ { diff --git a/apps/docs/src/docs/components/form-checkbox.md b/apps/docs/src/docs/components/form-checkbox.md index ab55a00a9..cd6ed24c3 100644 --- a/apps/docs/src/docs/components/form-checkbox.md +++ b/apps/docs/src/docs/components/form-checkbox.md @@ -934,7 +934,7 @@ const indeterminate = ref(true) v-model:indeterminate="asIndeterminate" aria-describedby="flavors" aria-controls="flavors" - @change="toggleAll" + @update:modelValue="toggleAll" > {{ allSelected ? 'Un-select All' : 'Select All' }} @@ -972,7 +972,7 @@ const indeterminate = ref(true) v-model:indeterminate="asIndeterminate" aria-describedby="flavors" aria-controls="flavors" - @change="toggleAll" + @update:modelValue="toggleAll" > {{ allSelected ? 'Un-select All' : 'Select All' }} diff --git a/packages/bootstrap-vue-next/src/components/BFormCheckbox/BFormCheckboxGroup.vue b/packages/bootstrap-vue-next/src/components/BFormCheckbox/BFormCheckboxGroup.vue index e12d78df6..8fe044145 100644 --- a/packages/bootstrap-vue-next/src/components/BFormCheckbox/BFormCheckboxGroup.vue +++ b/packages/bootstrap-vue-next/src/components/BFormCheckbox/BFormCheckboxGroup.vue @@ -21,7 +21,7 @@