Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(perf): avoid useless re-renders of component on parent update #4825

Merged
merged 42 commits into from May 11, 2020

Conversation

jacobmllr95
Copy link
Member

@jacobmllr95 jacobmllr95 commented Feb 25, 2020

Describe the PR

This PR should tackle performance issues with <b-form-*>, <b-link> and other components by avoiding useless re-renders on parent update.

This is derived from vuetifyjs/vuetify#8822, so thanks for the research to the Vuetify team!

See: vuejs/vue#7257
See: vuejs/vue#10115

TODO:

  • Adjust tests
  • Check overhead on component basis

PR checklist

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Enhancement
  • ARIA accessibility
  • Documentation update
  • Other (please describe)

Does this PR introduce a breaking change? (check one)

  • No
  • Yes (please describe)

The PR fulfills these requirements:

  • It's submitted to the dev branch, not the master branch
  • When resolving a specific issue, it's referenced in the PR's title (i.e. [...] (fixes #xxx[,#xxx]), where "xxx" is the issue number)
  • It should address only one issue or feature. If adding multiple features or fixing a bug and adding a new feature, break them into separate PRs if at all possible.
  • The title should follow the Conventional Commits naming convention (i.e. fix(alert): not alerting during SSR render, docs(badge): update pill examples, chore(docs): fix typo in README, etc). This is very important, as the CHANGELOG is generated from these messages.

If new features/enhancement/fixes are added or changed:

  • Includes documentation updates (including updating the component's package.json for slot and event changes)
  • Includes any needed TypeScript declaration file updates
  • New/updated tests are included and passing (if required)
  • Existing test suites are passing
  • CodeCov for patch has met target
  • The changes have not impacted the functionality of other components or directives
  • ARIA Accessibility has been taken into consideration (Does it affect screen reader users or keyboard only users? Clickable items should be in the tab index, etc.)

If adding a new feature, or changing the functionality of an existing feature, the PR's
description above includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

@jacobmllr95 jacobmllr95 added this to In progress in 2.6.1 via automation Feb 25, 2020
@tmorehouse tmorehouse changed the title fix(perf): avoid useless re-renders on parent update perf: avoid useless re-renders of component on parent update Feb 25, 2020
@tmorehouse
Copy link
Member

@codecov
Copy link

codecov bot commented Feb 25, 2020

Codecov Report

Merging #4825 into dev will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##               dev     #4825   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          281       281           
  Lines         8862      8862           
  Branches      2510      2510           
=========================================
  Hits          8862      8862           
Flag Coverage Δ
#unittests 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c282cdd...c282cdd. Read the comment docs.

@jacobmllr95 jacobmllr95 added this to In progress in 2.6.0 via automation Feb 26, 2020
@jacobmllr95 jacobmllr95 removed this from In progress in 2.6.1 Feb 26, 2020
@tmorehouse tmorehouse added this to In progress in 2.6.1 via automation Mar 2, 2020
@tmorehouse tmorehouse removed this from In progress in 2.6.0 Mar 2, 2020
@jacobmllr95 jacobmllr95 removed this from In progress in 2.6.1 Mar 5, 2020
@vercel vercel bot temporarily deployed to Preview May 10, 2020 11:11 Inactive
@vercel vercel bot temporarily deployed to Preview May 10, 2020 11:13 Inactive
@vercel vercel bot temporarily deployed to Preview May 10, 2020 12:54 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
No open projects
v2.14.0
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants