New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(b-table, b-table-lite, b-table-simple): handle header variant for sticky columns (fixes #5278) #5279
Conversation
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/bootstrap-vue/bootstrap-vue/77kxeqm40 |
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit cdac3e7:
|
Codecov Report
@@ Coverage Diff @@
## dev #5279 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 280 280
Lines 8714 8721 +7
Branches 2489 2491 +2
=========================================
+ Hits 8714 8721 +7
Continue to review full report at Codecov.
|
Describe the PR
Handle case where sticky column does not preserve
head-variant
(orfoot-variant
)Fixes #5278
Also increases covered line/branches due to removal of old istanbul ignores
PR checklist
What kind of change does this PR introduce? (check at least one)
fix(...)
, requires a patch version updatefeat(...)
, requires a minor version updatefeat(...)
, requires a minor version updatefix(...)
, requires a patch or minor version updatechore(docs)
, requires a patch version updateDoes this PR introduce a breaking change? (check one)
The PR fulfills these requirements:
dev
branch, not themaster
branch[...] (fixes #xxx[,#xxx])
, where "xxx" is the issue number)fix(alert): not alerting during SSR render
,docs(badge): update pill examples
,chore(docs): fix typo in README
, etc). This is very important, as theCHANGELOG
is generated from these messages, and determines the next version type (patch or minor).If new features/enhancement/fixes are added or changed:
If adding a new feature, or changing the functionality of an existing feature, the PR's
description above includes: