New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(v-b-toggle): support specifying target ID via directive argument, and array of target IDs via directive value (closes #4834) #5336
Conversation
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/bootstrap-vue/bootstrap-vue/dewqemcs4 |
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit aa41484:
|
Codecov Report
@@ Coverage Diff @@
## dev #5336 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 280 280
Lines 8793 8793
Branches 2509 2509
=========================================
Hits 8793 8793
Continue to review full report at Codecov.
|
Describe the PR
not-collapsed
to the trigger element when the target(s) are expandedCloses #4834
To Do:
utils/target
code tov-b-toggle
directive code, and removeutils/target
sincev-b-toggle
is the only directive that uses itv-b-toggle
check ifevt.defaultPrevented
before calling handler(s)not-collapsed
to trigger element when target is not collapsedtabindex
and keydown handlers for accessibility<b-navbar-toggle>
to usev-b-toggle
directivev-b-toggle
b-navbar-toggle
(to note that it can be used to control sidebars as well, and note that it usesv-b-toggle
directive internally)Future (separate PRs, after this PR is merged):
data-class-*
sniffing on the trigger element to allow for custom classes for collapsed/not-collapsed' states (Issue Add custom collapse/not-collapsed classes to collapse button #4476)PR checklist
What kind of change does this PR introduce? (check at least one)
fix(...)
, requires a patch version updatefeat(...)
, requires a minor version updatefeat(...)
, requires a minor version updatefix(...)
, requires a patch or minor version updatechore(docs)
, requires a patch version updateDoes this PR introduce a breaking change? (check one)
The PR fulfills these requirements:
dev
branch, not themaster
branch[...] (fixes #xxx[,#xxx])
, where "xxx" is the issue number)fix(alert): not alerting during SSR render
,docs(badge): update pill examples
,chore(docs): fix typo in README
, etc). This is very important, as theCHANGELOG
is generated from these messages, and determines the next version type (patch or minor).If new features/enhancement/fixes are added or changed:
If adding a new feature, or changing the functionality of an existing feature, the PR's
description above includes: