Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Progress bar text not showing correctly #5516

Closed
jsbroks opened this issue Jun 20, 2020 · 7 comments
Closed

Progress bar text not showing correctly #5516

jsbroks opened this issue Jun 20, 2020 · 7 comments

Comments

@jsbroks
Copy link

jsbroks commented Jun 20, 2020

Describe the bug

Progressbar text is not going to a new line. This screenshot is from the docs.
image

Steps to reproduce the bug

  1. Create a progress bar with multiple lines of text

Expected behavior

All text should be visible

Versions

Libraries:

  • BootstrapVue: 2.15.0

Environment:

  • Device: Desktop
  • OS: Ubuntu 20.04
  • Browser: Chrome
@jsbroks jsbroks changed the title Progress bar text not loading correctly Progress bar text not showing correctly Jun 20, 2020
@Hiws
Copy link
Member

Hiws commented Jun 20, 2020

This looks to be an issue with a change made in bootstrap v4.5.0 that added line-height: 0 to the progress class.

To fix it you can add the following CSS, to get it back to pre 4.5.0 styling.

.progress {
  line-height: initial;
}

@Hiws
Copy link
Member

Hiws commented Jun 20, 2020

PR that introduced the change: twbs/bootstrap#29413

So if IE11 support is something your app needs, you might want to check what the workaround above does, to make sure it doesn't cause any issues.

@jsbroks
Copy link
Author

jsbroks commented Jun 20, 2020

Thanks! How would I remove the line break in the first place?

@Hiws
Copy link
Member

Hiws commented Jun 20, 2020

Thanks! How would I remove the line break in the first place?

You want it to say "Progress: 50/100" on one line instead of two?

If that's the case, just wrap the content in a single div.

<b-progress-bar :value="value">
  <div>
    Progress: <strong>{{ value.toFixed(2) }} / {{ max }}</strong>
  </div>
</b-progress-bar>

@stale
Copy link

stale bot commented Sep 19, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contribution.

@stale stale bot added the Status: Stale label Sep 19, 2020
@stale
Copy link

stale bot commented Sep 27, 2020

Closing this issue after a prolonged period of inactivity. If this issue is still present in the latest release, please create a new issue with up-to-date information. Thank you!

@stale stale bot closed this as completed Sep 27, 2020
@stale
Copy link

stale bot commented Oct 4, 2020

Closing this issue after a prolonged period of inactivity. If this issue is still present in the latest release, please create a new issue with up-to-date information. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants