Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

b-dropdown-item-button has inconsistent styling with b-dropdown-item in Chromium browsers #5943

Closed
bbugh opened this issue Oct 21, 2020 · 4 comments

Comments

@bbugh
Copy link
Contributor

bbugh commented Oct 21, 2020

Describe the bug

In Chromium, b-dropdown-item-button shows a border when clicked (on :focus), but b-dropdown-item doesn't.

image

(Backgrounds are lightened to show the border effect)

b-dropdown-item-button seems to be picking up the button outline: -webkit-focus-ring-color effect from Reboot. Firefox does not support -webkit-focus-ring-color so it show the single dotted outline.

https://github.com/twbs/bootstrap/blob/ebd9eb105ab094af747c09082ced1df71aaec123/scss/_reboot.scss#L419-L422

Steps to reproduce the bug

  1. Use a b-dropdown-item-button
  2. Click on it and observe the blue border

demo

Expected behavior

I would expect the designs of these to behave consistently on all browsers, either both with or both without the outline (preferably without).

Versions

Libraries:

  • BootstrapVue: 2.16.0
  • Bootstrap: 4.5.3
  • Vue: 2.6.12

Environment:

  • Device: Mac
  • OS: Mojave
  • Browser: Firefox, Chromium
  • Version: 81.02, 86.0.4240.99

Demo link

https://codesandbox.io/s/b-dropdown-item-button-styling-1ier8?file=/App.vue

@Hiws
Copy link
Member

Hiws commented Oct 21, 2020

This behavior looks to be the same as with native Bootstrap.
https://getbootstrap.com/docs/4.5/components/dropdowns/#menu-items
https://v5.getbootstrap.com/docs/5.0/components/dropdowns/#menu-items

So I don't think we should change this behavior here, as this is more of an upstream issue.
You could try suggesting it on Bootstrap's GitHub.
https://github.com/twbs/bootstrap/issues

@bbugh
Copy link
Contributor Author

bbugh commented Oct 21, 2020

Looks like you're right. I thought I checked it in upstream bootstrap, but it's not impossible that while juggling a bunch of browsers I looked at it in Firefox by accident and thought it was fine.

It looks like @tmorehouse has brought this same issue up a few times on bootstrap's repo. twbs/bootstrap#23329 (comment) and twbs/bootstrap#23990 (comment).

I made a new issue over there: twbs/bootstrap#31949

@stale
Copy link

stale bot commented Jan 23, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contribution.

@stale stale bot added the Status: Stale label Jan 23, 2021
@stale
Copy link

stale bot commented Jun 28, 2021

Closing this issue after a prolonged period of inactivity. If this issue is still present in the latest release, please create a new issue with up-to-date information. Thank you!

@stale stale bot closed this as completed Jun 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants