Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Memory leak in InactivityMonitor in irc.py #13

Open
KeyszerS opened this issue Jan 26, 2022 · 1 comment
Open

Memory leak in InactivityMonitor in irc.py #13

KeyszerS opened this issue Jan 26, 2022 · 1 comment

Comments

@KeyszerS
Copy link

A change in Python at version 3.7.4 introduced a leak for any thread that doesn't get it's "join" method called.
See https://bugs.python.org/issue43050
See also https://bugs.python.org/issue37788

Here is fixed function:

    def _clear_timers(self):
        """Cancel scheduled execution of the timers."""
        for timer in [self._timer_ping, self._timer_abort]:
            if timer is not None:
                timer.cancel()
                timer.join()
@boreq
Copy link
Owner

boreq commented Jul 6, 2022

As far as I can see those bugs were fixed already which probably means that a fix is no longer necessary. Can you confirm that?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants