You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Apr 4, 2024. It is now read-only.
We have batches failing with {"message":"Waiting on code owner review from ComposableFi/core, ComposableFi/parachain, ComposableFi/parachain-leads, and/or ComposableFi/sre.","documentation_url":"https://docs.github.com/articles/about-protected-branches"}, yet the code owners already approved.
Previously we had batches including a bad PR that got to staging, and then the CODEOWNERS was updated, failing the entire batch. In this case it is just this singular PR.
The text was updated successfully, but these errors were encountered:
We have the same issue. If the merge includes multiple PRs and some of them need CODEOWNERS approval, bors seems to get confused. Building that PR on its own is the solution but this wastes a lot of time.
We are also experiencing this problem which is causing a lot of inconvenience to us.
e.g. a batch of 4 PR's getting executed -> All checks are passing -> But, then BORS decides to cancel the batch even though the concerned PR in the batch has approval from all the required code owner groups
Are there any plans to address this problem?
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
We have batches failing with
{"message":"Waiting on code owner review from ComposableFi/core, ComposableFi/parachain, ComposableFi/parachain-leads, and/or ComposableFi/sre.","documentation_url":"https://docs.github.com/articles/about-protected-branches"}
, yet the code owners already approved.Example of a failing PR: ComposableFi/composable#1251
Previously we had batches including a
bad
PR that got to staging, and then the CODEOWNERS was updated, failing the entire batch. In this case it is just this singular PR.The text was updated successfully, but these errors were encountered: