Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 1.4 #1732

Closed
16 tasks done
sheerun opened this issue Mar 11, 2015 · 16 comments
Closed
16 tasks done

Release 1.4 #1732

sheerun opened this issue Mar 11, 2015 · 16 comments

Comments

@sheerun
Copy link
Contributor

sheerun commented Mar 11, 2015

For 1.4 I want to release only few features:

It'll also include greatly improved test coverage (~60% -> ~88%), and many refactors.

I hope it'll break vicious cycle of patch releases.

Things to do before release:

  • Finish tests for bower login (@sheerun)
  • Implement two-factor authentication for login command
  • Review diff of all non-test changes (e.g. probably SVNResolver needs some reverting, see windows slash appended to svn info by bower #1721)
  • Create release draft on GitHub with all changes
  • Review of master branch
  • Bump package.json to 1.4.0, publish tag on github, and release on npm

@samccone Anything you'd like to add?

@sheerun sheerun added this to the 1.4 milestone Mar 11, 2015
@samccone
Copy link
Member

hey @sheerun let me get all caught up on the notifications and take a look at what you have done.
I think login and unregister commands is the last big thing in my mind .. but will come back to this 👍

@sheerun
Copy link
Contributor Author

sheerun commented Mar 30, 2015

@samccone @nwinkler @desandro @benschwarz @satazor

1.4.0 is ready to be released on master branch. Could you review? (especially login / unregister feature, but also other changes mentioned above). I'd like to release tomorrow if you see no issues.

@sheerun
Copy link
Contributor Author

sheerun commented Mar 30, 2015

Oh, also @zanona and @kodypeterson

@sheerun
Copy link
Contributor Author

sheerun commented Mar 30, 2015

btw. It's more about testing if mentioned features actually work, rather than reviewing the code :)

@nwinkler
Copy link
Contributor

Sure - I'll take a look at this today. I'll be testing the #1628 functionality.

@nwinkler
Copy link
Contributor

I've tested the #1628 Shallow Cloning option against the following:

  • GitHub.com
  • BitBucket.org
  • Our on-premise Atlassian Stash instance

All three work fine, shallow cloning is enabled automatically for them, based on the server's response.

I don't have access to a GitHub Enterprise instance to verify it against that. Does anyone have access to an instance they could test this with?

When you run bower install --verbose, there should be a line like the following for non-GitHub hosts:

bower repo#master detect-smart-git Smart Git host detected: true

For GitHub Enterprise, it should print false instead of true, resulting in a full clone, not a shallow one.

@desandro
Copy link
Member

Success!

  • Able to login with username -> password -> 2FA
  • Unregistered previous package tap-listener
  • Registered new package taplistener to git://github.com/metafizzy/tap-listener.git
  • Unregistered new package taplistener
  • Re-registered previous package tap-listener

@samccone
Copy link
Member

👏 awesome @desandro

@kodypeterson
Copy link

looks good to me!

@sheerun
Copy link
Contributor Author

sheerun commented Mar 30, 2015

Released 1.4.0. Thank you all for support!

@benschwarz
Copy link
Member

Congrats @sheerun !

@patrickkettner
Copy link
Member

hurray! freakin awesome work, @sheerun.

@nwinkler
Copy link
Contributor

Excellent - thanks, @sheerun!

@sheerun
Copy link
Contributor Author

sheerun commented Mar 31, 2015

I've added some of you to release credits. Sorry if I forgot about someone. Thanks again!

@sheerun sheerun closed this as completed Mar 31, 2015
@zanona
Copy link
Contributor

zanona commented Mar 31, 2015

That's great! thanks a lot @sheerun

@samccone
Copy link
Member

👏 amazing work @sheerun 💖

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

8 participants