Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flip Behavior of shallowCloneHosts #2031

Closed
ghost opened this issue Nov 20, 2015 · 4 comments
Closed

Flip Behavior of shallowCloneHosts #2031

ghost opened this issue Nov 20, 2015 · 4 comments

Comments

@ghost
Copy link

ghost commented Nov 20, 2015

As per 26f80d2 enabling shallow cloning of a bower component requires that a .bowerrc file exist, and that the file white lists the git repository host.

The change was required because of issues with GitHub Enterprise and RhodeCode (As documented on #1764).

Therefore, projects that are on neither host are required to expend resources training their community to setup a .bowerrc file, or add .bowerrc files to their projects, because of an issue in a SCM they don't even use.

Therefore, could the behavior be swapped in the next major release of Bower such that shallow cloning, using the HTTP header, is on by default, and that users of misbehaving SCMs must black list their hosts in a .bowerrc file?

@achembarpu
Copy link

+1 - I would like to see this, as well, since the misbehaving git hosts are rare, in comparison.

Having bower do a full clone for everyone, everytime, by default, seems wasteful.

At the very least, a force-enable command line switch would be useful...

Thoughts?

@sheerun
Copy link
Contributor

sheerun commented Nov 27, 2015

We can't break backward compatibility for bower 1.x. This is a breaking change.

We can introduce --beta flag or something, though.

@ghost
Copy link
Author

ghost commented Nov 27, 2015

@sheerun that's why I mentioned a major release. I believe this change must wait until the next major release to ensure we don't break any existing workflows.

However, I do believe the behavior should be flipped as part of the next major release. I also believe that users of misbehaving hosts should be expected to disable the shallow clone feature as needed.

Personally, adding --beta is only marginally better since it still requires intervention on the part of a developer that wants to take advantage of shallow cloning.

@sheerun
Copy link
Contributor

sheerun commented Apr 27, 2020

Major release of Bower is not planned anymore

@sheerun sheerun closed this as completed Apr 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

3 participants