Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Entering bower search lists all packages which takes a while #2066

Closed
heinst opened this issue Nov 30, 2015 · 10 comments · Fixed by marekventur/wortopia-node#124
Closed

Entering bower search lists all packages which takes a while #2066

heinst opened this issue Nov 30, 2015 · 10 comments · Fixed by marekventur/wortopia-node#124
Assignees

Comments

@heinst
Copy link
Member

heinst commented Nov 30, 2015

Entering bower search with no entry causes bower to list all packages, this process takes a long time. As an alternative maybe bower should say no search was entered and then ask the user if they would like to list all packages instead of being hung up for about 10 seconds

Resolved by Pull #2074

@heinst heinst self-assigned this Nov 30, 2015
@heinst heinst changed the title Entering bower search with no entry causes bower to hang indefinitely Entering bower search lists all packages which takes a while Nov 30, 2015
@tejgop
Copy link

tejgop commented Nov 30, 2015

Good idea, either that or bower should return nothing.

@eppeters
Copy link
Contributor

I think it is better to be explicit and let the user know their query failed because it needed more information. Alternatively, we could warn: This will list all (more than X) Bower packages, and will take a while. Continue? y/N

@tejgop
Copy link

tejgop commented Nov 30, 2015

Actually there should be a threshold, like 100 to give that warning.

@sheerun
Copy link
Contributor

sheerun commented Nov 30, 2015

Any PR that improves this behaviour is welcome

@heinst
Copy link
Member Author

heinst commented Dec 3, 2015

Pull request #2074 resolves this issue

@heinst heinst closed this as completed Dec 3, 2015
@segrey
Copy link

segrey commented Dec 11, 2015

Hi guys!
Is there now a way to retrieve all bower packages using cli? It's a needed operation for WebStorm Bower integration. Previously, IDE just run bower search --json and parsed JSON output.

@sheerun sheerun reopened this Dec 11, 2015
@sheerun
Copy link
Contributor

sheerun commented Dec 11, 2015

It turns out the implementation AND tests are wrong... We should display all packages when --json is passed.

@eppeters
Copy link
Contributor

I can work on fixing this today if no one else is.

@segrey
Copy link

segrey commented Dec 11, 2015

Thank you for the fast respond. Yep, --json would be a good trigger. Meanwhile, bower search "" --json is used as a workaround. FYI, I think I observed several time some text prefix (like some debug output) before JSON body result. Unfortunately, it cannot be reproduced anymore.

@segrey
Copy link

segrey commented Dec 11, 2015

Thank you for the quick turnaround!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging a pull request may close this issue.

5 participants