Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Could we connect sslStrict configuration value with GIT_SSL_NO_VERIFY #2129

Closed
pwielgolaski opened this issue Jan 2, 2016 · 1 comment
Closed

Comments

@pwielgolaski
Copy link
Contributor

I think it could solve many issues reported with corporate proxies.
When I set ssl-strict: false, it only works for http calls, but it will fail when I use git command like

value = cmd('git', ['ls-remote', '--heads', this._source], {

Not I need to change configuration of my git to also ignore SSL certificate, but it could be more comprehensive if we export GIT_SSL_NO_VERIFY=true when ssl-strict=false.

What do you think, I could start to work on PR, but I wonder if it will be accepted and if it should belong to bower or bower-config project

Some links:
https://blog.breadncup.com/2011/06/09/skip-git-ssl-verification/
http://stackoverflow.com/questions/9008309/how-do-i-set-git-ssl-no-verify-for-specific-repos-only

@sheerun
Copy link
Contributor

sheerun commented Jan 3, 2016

It's a good idea :)

sheerun added a commit that referenced this issue Jan 24, 2016
when strictSsl is false set GIT_SSL_NO_VERIFY=true for git command
@sheerun sheerun closed this as completed Jan 26, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

3 participants