Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrong result in WindowsWechat #380

Closed
Tindtily opened this issue Dec 17, 2019 · 1 comment
Closed

Wrong result in WindowsWechat #380

Tindtily opened this issue Dec 17, 2019 · 1 comment

Comments

@Tindtily
Copy link

Template to report about browser detection issue

window.navigator.userAgent of the browser is:

Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_1) AppleWebKit/605.1.15 (KHTML, like Gecko) Chrome/39.0.2171.95 Safari/537.36 MicroMessenger/6.5.2.501 NetType/WIFI WindowsWechat

And it's detected os is Windows
However, the real os of the browser is Mac OS
The windows regex in src/parser-os.js should be 'windows /i' instead of 'windows/i'
@Tindtily Tindtily mentioned this issue Dec 17, 2019
Merged
@lancedikson
Copy link
Collaborator

It's been fixed with the 2.8.0 release. Thanks for your help! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@lancedikson @Tindtily