Skip to content
This repository has been archived by the owner on Sep 6, 2020. It is now read-only.

Download signature with installer #139

Open
mbrodala opened this issue May 2, 2016 · 5 comments
Open

Download signature with installer #139

mbrodala opened this issue May 2, 2016 · 5 comments

Comments

@mbrodala
Copy link
Contributor

mbrodala commented May 2, 2016

The installer script currently only downloads the latest .phar. To check the integrity of that file, one has to manually download the matching signature (see #123) from Github releases.

It would be useful if the installer did this automatically and download the box.phar.sig next to the box.phar, thus one can simply run gpg --verify box.phar.sig box.phar afterwards.

@kherge
Copy link
Contributor

kherge commented May 4, 2016

I'm leaning towards no on this issue because I feel like this will give users a false sense of security GitHub does become compromised.

@mbrodala
Copy link
Contributor Author

mbrodala commented May 4, 2016

Not sure where a false sense of security could be given. Even if Github is compromised and both the .phar and .phar.sig have been tampered with, a check via GPG and your public key will reveal this.

This issue is simply about convenience without any security change.

@mbrodala
Copy link
Contributor Author

mbrodala commented May 4, 2016

Of course, to be absolutely sure I'd have to meet you in person and verify that the public key I have retrieved is really yours. ;-)

@kherge
Copy link
Contributor

kherge commented May 4, 2016

Would it be reasonable to assume that if any of the release files are tampered with, that the files used in the gh-pages branch could also be tampered with? I can imagine a situation where the install script is modified to bypass the GPG check and falsely report that it succeeded.

@mbrodala
Copy link
Contributor Author

mbrodala commented May 6, 2016

But I didn't request the install script to perform the GPG verification, did I? ;-)

Again, all I'm requesting is to conveniently download the .phar.sig, nothing more. The check must still be performed by the user of course.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants