Skip to content
This repository has been archived by the owner on Sep 6, 2020. It is now read-only.

Binary Finder/Directories not actually direct copies, custom finders get settings overwritten #82

Open
tedivm opened this issue Jun 28, 2014 · 2 comments
Milestone

Comments

@tedivm
Copy link

tedivm commented Jun 28, 2014

I need to include a directly completely as is- with empty folders intact, and with version control files there if they happen to exist. This is currently impossible with this application.

The problem is in the processFinders function. Line 1077 restricts finders to only files, and 1079 removes all of the version control files. Every finder that's configured- directory-bin, finder-bin, finder, etc- gets passed to this function. This makes it impossible to include these files even when that's desired.

@tedivm
Copy link
Author

tedivm commented Jun 28, 2014

Actually a correction- I can overwrite the version control option, since my configuration will be called after that function is called. I've got a solid hack around the "files" issue, so don't consider this a high priority.

@tedivm tedivm changed the title Binary Finder/Directories not actually direct copies, customer finders get settings overwritten Binary Finder/Directories not actually direct copies, custom finders get settings overwritten Jun 28, 2014
@ghost ghost added the Enhancement label Jun 30, 2014
@ghost ghost self-assigned this Jun 30, 2014
@ghost ghost added this to the 3.0 milestone Jun 30, 2014
@ghost
Copy link

ghost commented Jun 30, 2014

This will be something I can fix in the next iteration of Box.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

1 participant