Multiple paths-to-mutate,exclude or test are not correctly parsed

[gregori]

If you pass multiple paths to any of the path switches, they're not correctly parsed if the pathname contains a "/".

i.e.: --paths-to-mutate app/model,app/service,app/controller

I've checked the code and the problem relies on the get_pattern method. It can simply be solved by changing the regex there:

def get_pattern(char):
        return re.compile(rf"^([\w\/]+)({char}\s*[\w\/]+)*$")

[boxed]

Looks like you're on unix. The correct separator for paths is : in unix.

[gregori]

In fact it doesn't work, neither with ":" nor ",". The problem is the matching RE pattern.

\w means [a-zA-Z0-9_], but if you pass a filename with any directories, it won't work.
i.e: app/package or in windows app\package

now that you mention, my suggestion for that pattern build must also include \. Maybe we should use:

def get_pattern(char):
    return re.compile(rf"^(\w\/\\]+)({char}\s*[\w\/\\]+)*$")

[boxed]

Hmm. yea ok. I guess the split should include both / and \ on windows, but only \ on unix? Ugh.

[DanJBower]

@gregori @boxed I'm confused, where is get_pattern defined? I tried using --paths-to-mutate on Windows but it only seems to accept 1 path and not multiple. If more than one is provided it raises an error saying it is either expecting a file path or an integer

[boxed]

@DanJBower yea, this issue is saying that paths-to-mutate doesn't work for multiple paths.

[DanJBower]

Ah okay, thanks for clarifying

When I read it yesterday, I thought it was unix specific

[dversoza]

I just added a PR to explain better how the paths-to-mutate attribute works.