Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Node 10 #35

Closed
mikedidomizio opened this issue Apr 25, 2018 · 1 comment
Closed

Support Node 10 #35

mikedidomizio opened this issue Apr 25, 2018 · 1 comment
Labels
bug Something isn't working build issues related to the build

Comments

@mikedidomizio
Copy link
Member

With the release of Node 10, the builds started failing here:
https://travis-ci.org/boxing/boxrec/builds/371282493

I noticed that the Node version was 10 and the last successful build was with Node 8. Specifying Node 8 resulted in a successful build:
https://travis-ci.org/boxing/boxrec/builds/371289454

TypeError: Cannot assign to read only property 'asyncIterator' of function 'function Symbol() { [native code] }'

This line may have something to do with it:
https://github.com/boxing/boxrec/blob/master/src/boxrec.class.ts#L9

  • The fix should also support Node 8
  • Possibly should be a fix release for this
@mikedidomizio mikedidomizio added bug Something isn't working build issues related to the build labels Apr 25, 2018
@mikedidomizio
Copy link
Member Author

Fixed the issue

Merge Request: #48
Build with Node 10 enabled: https://travis-ci.org/boxing/boxrec/builds/381938578

There are some warnings in the build, seems to be related to this

Kept .travis.yml on Node 8 for the time being

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working build issues related to the build
Projects
None yet
Development

No branches or pull requests

1 participant