Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge Previews and thumbnail generation #806

Open
bpatrik opened this issue Jan 3, 2024 · 8 comments
Open

Merge Previews and thumbnail generation #806

bpatrik opened this issue Jan 3, 2024 · 8 comments
Assignees

Comments

@bpatrik
Copy link
Owner

bpatrik commented Jan 3, 2024

Merge thumbnail and photo previews, so the app can handle them the same way and interchangeably use them.

This will also help with raw photo support.

@bpatrik
Copy link
Owner Author

bpatrik commented Jan 3, 2024

NOTE: this commit will most likely trigger a full thumbnail recreation

@rhatguy
Copy link

rhatguy commented Jan 4, 2024

Was it intentional to change the thumbnail preview sizes? Seems like new larger options were added with this commit (1080 and 2160) which were not there previously. Could be my lack of understanding in the purpose of this change.

@bpatrik
Copy link
Owner Author

bpatrik commented Jan 6, 2024

Yes. I wanted to increase the thumbnail sizes for better look. You can override them to the previous values: should be something like 240, 480, 1080.

This change merges thumbnails with previews. So there is only one list of sizes to maintain. App will load the one that fits the best to the thumbnail or preview bounding box.

@bpatrik
Copy link
Owner Author

bpatrik commented Jan 6, 2024

also adding 2160 size adds 4k preview support.

bpatrik added a commit that referenced this issue Jan 6, 2024
@tschaerni
Copy link

I couldn't find any hint anywhere, and because my question has to do with thumbnail generation, I thought I'd ask here:
Is there are way to pre generate the thumbnails? I have about 900GB of pictures, and some of them are very high resolution, and it takes sometimes up to 5-10 min for a full folder to generate the thumbnails, which is rather annoying.

If there isn't a way to pre generate all thumbnails, maybe that could be added as a feature? Would help a lot with the initial setup, especially if you have a big gallery.

Cheers

@rhatguy
Copy link

rhatguy commented Feb 2, 2024

Thats what the "Photo converting" job does. If you check in settings you can select what preview sizes you want it to generate and when you execute the job it will run through your entire collection and pre-generate the previews for each of those sizes.

@tschaerni
Copy link

tschaerni commented Feb 2, 2024

Thats what the "Photo converting" job does. If you check in settings you can select what preview sizes you want it to generate and when you execute the job it will run through your entire collection and pre-generate the previews for each of those sizes.

Thanks for that tipp! I seem to have overlooked the thumbnail generation button ^^'

PS: It tells me it'll take 4h to do so >.<

@bpatrik
Copy link
Owner Author

bpatrik commented Feb 4, 2024

The best settings depends on your setup. If you have a powerful machine:

Save CPU -> pre generate thumbnail
Save network -> more thumbnail sizes
Save disk -> do not pregenerate
Better image quality -> bigger thumbnail sizes

I use the def. settings. I usually only pregenerate the smallest thumbnail. The app will do on demand the rest. I'm using now an Intel NUC. Earlier on reaspberry i pregenerated more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants