Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

User token #1157

Open
sergelogvinov opened this issue Mar 24, 2024 · 1 comment
Open

User token #1157

sergelogvinov opened this issue Mar 24, 2024 · 1 comment
Labels
✨ enhancement New feature or request

Comments

@sergelogvinov
Copy link
Contributor

Is your feature request related to a problem? Please describe.

Create a user token.

Describe the solution you'd like

resource "proxmox_virtual_environment_user_token" "kubernetes" {
  # required params
  user_id = "prometheus@pve"
  token_id = "kubernetes"

  # optional
  acl {
    path      = "/"
    propagate = true
    role_id   = "PVEAuditor"
  }

  separate = false
  comment = "Prometheus token"
  expiration_date = "2035-12-31T23:59:59Z"
}

What do you think?

@sergelogvinov sergelogvinov added the ✨ enhancement New feature or request label Mar 24, 2024
@bpg
Copy link
Owner

bpg commented Mar 25, 2024

Hi @sergelogvinov 👋🏼 I believe this is about the API Tokens
If so, there is a feature request already: #740, which I don't mind to close, and keep this one.

The resource model makes sense to me. I would rename the resource to proxmox_virtual_environment_api_token though.
And I saw your WIP branch, having the "user token" naming there is fine.
Also, the separate attribute could be renamed to more explicit "privilege_separation" for more clarity.

Speaking about the implementation, I would like to have all new resource and datasources to be created using the Plugin Framework. My long term plan is to refactor all existing resources to the framework.
You can find some example under /fwprovider folder.

Hope it make sense, pls let me know if you have any questions 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✨ enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants