Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed input value re-appears in template defined text field #685

Open
nikku opened this issue May 18, 2022 · 2 comments
Open

Removed input value re-appears in template defined text field #685

nikku opened this issue May 18, 2022 · 2 comments
Labels
backlog Queued in backlog bug Something isn't working connectors element templates spring cleaning Could be cleaned up one day ux

Comments

@nikku
Copy link
Member

nikku commented May 18, 2022

Describe the Bug

As a user, when removing the input of a required field it is actually not removed (it is invalid and this not persisted). Instead it re-appears when I re-select the element:

restthingproperties

Steps to Reproduce

  • Model a template task A with a required text binding
  • Input text FOO => validation error disappears
  • Remove text => validation error appears
  • Focus another element, and focus A again
  • You see that A has FOO as an input text again

Expected Behavior

I'd expect the value to actually be removed, similar to how we handle most errors nowadays.

Environment

  • Host (Browser/Node version), if applicable: Any
  • OS: Linux (Any)
  • Library version: v1.0.0

Initially reported as connectors feedback via this channel

@nikku nikku added bug Something isn't working connectors element templates labels May 18, 2022
@nikku
Copy link
Member Author

nikku commented May 18, 2022

Intuitively for me this is a case for linting (and our lighter version of validation).

CC @andreasgeier

@pinussilvestrus pinussilvestrus added backlog Queued in backlog spring cleaning Could be cleaned up one day labels Jun 3, 2022
@nikku
Copy link
Member Author

nikku commented Jun 10, 2022

@christian-konrad Could you have a look into this, understand and assess it?

@nikku nikku added the ux label Jun 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backlog Queued in backlog bug Something isn't working connectors element templates spring cleaning Could be cleaned up one day ux
Development

No branches or pull requests

2 participants