Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorporate color and alignment helpers into context pad #1491

Closed
2 tasks
nikku opened this issue Sep 24, 2021 · 2 comments
Closed
2 tasks

Incorporate color and alignment helpers into context pad #1491

nikku opened this issue Sep 24, 2021 · 2 comments
Labels
enhancement New feature or request

Comments

@nikku
Copy link
Member

nikku commented Sep 24, 2021

Is your feature request related to a problem? Please describe.

Coloring and alignment utilities are currently only exposed via API and been must be provided to users via custom UI controls.

For the sake of a unified modeling experience it would make sense to make these elements available directly from the modeler user interface.

Describe the solution you'd like

These actions are available through the context pad:

Describe alternatives you've considered

Keep it as is.

Additional context

All mentioned tools are multi element, which we do not support in the context pad just yet (bpmn-io/diagram-js#278).


Depends on bpmn-io/diagram-js#587
Related PR: #1525

@nikku nikku added the enhancement New feature or request label Sep 24, 2021
@pinussilvestrus pinussilvestrus added the backlog Queued in backlog label Oct 7, 2021
@nikku
Copy link
Member Author

nikku commented Nov 9, 2021

A demo showcasing this end-to-end is available here (link to respective multi-element-context-pad branches in bpmn-js and bpmn-js -> diagram-js.

Demo using the feature end-to-end:

capture AJc7CN_optimized

@smbea smbea changed the title Incorporate color and alignment helpers into the core editor Incorporate color and alignment helpers into context pad May 19, 2022
@smbea smbea linked a pull request May 19, 2022 that will close this issue
3 tasks
@smbea smbea removed a link to a pull request May 19, 2022
3 tasks
smbea added a commit that referenced this issue May 19, 2022
smbea added a commit that referenced this issue May 19, 2022
smbea added a commit that referenced this issue May 19, 2022
smbea added a commit that referenced this issue May 19, 2022
smbea added a commit that referenced this issue May 19, 2022
smbea added a commit that referenced this issue May 20, 2022
smbea added a commit that referenced this issue May 20, 2022
@nikku
Copy link
Member Author

nikku commented Jul 5, 2023

These are now incorporated via different places, available at the core, or dedicated utilities: #1680, https://github.com/bpmn-io/bpmn-js-color-picker.

@nikku nikku closed this as completed Jul 5, 2023
@bpmn-io-tasks bpmn-io-tasks bot removed the backlog Queued in backlog label Jul 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Development

No branches or pull requests

2 participants