Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Display alignment & distribution buttons only when it makes sense #1691

Closed
barmac opened this issue Jun 29, 2022 · 0 comments · Fixed by #1682
Closed

Display alignment & distribution buttons only when it makes sense #1691

barmac opened this issue Jun 29, 2022 · 0 comments · Fixed by #1682
Assignees
@barmac

Comments

@barmac
Copy link
Member

barmac commented Jun 29, 2022

What should we do?

Don't display the buttons if distribution/alignment cannot possibly have any effect, e.g. when only a sequence flow and a task are selected.

Why should we do it?

No surprises.

Follow-up of #1680
@barmac barmac added the ready Ready to be worked on label Jun 29, 2022
@barmac barmac self-assigned this Jun 29, 2022
@barmac barmac mentioned this issue Jun 29, 2022
Merged
barmac added a commit that referenced this issue Jul 5, 2022
@barmac
feat: implement rules for alignment and distribution
b0bf534 
Closes #1691
@bpmn-io-tasks bpmn-io-tasks bot added in progress Currently worked on and removed ready Ready to be worked on labels Jul 5, 2022
barmac added a commit that referenced this issue Jul 5, 2022
@barmac
feat: add alignment and distribution menu multi-element context pad
4fb918e 
Closes #1680
Closes #1691
barmac added a commit that referenced this issue Jul 6, 2022
@barmac
feat: add alignment and distribution menu multi-element context pad
598ccc4 
Closes #1680
Closes #1691
barmac added a commit that referenced this issue Jul 6, 2022
@barmac
feat: add alignment and distribution menu multi-element context pad
008af35 
Closes #1680
Closes #1691
barmac added a commit that referenced this issue Jul 6, 2022
@barmac
feat: add alignment and distribution menu multi-element context pad
62b315f 
Closes #1680
Closes #1691
@bpmn-io-tasks bpmn-io-tasks bot added needs review Review pending and removed in progress Currently worked on labels Jul 6, 2022
barmac added a commit that referenced this issue Jul 6, 2022
@barmac
feat: add alignment and distribution menu multi-element context pad
a980d70 
Closes #1680
Closes #1691
barmac added a commit that referenced this issue Jul 6, 2022
@barmac
feat: add alignment and distribution menu multi-element context pad
27ae402 
Closes #1680
Closes #1691
barmac added a commit that referenced this issue Jul 7, 2022
@barmac
feat: add alignment and distribution menu multi-element context pad
2c75c8f 
Closes #1680
Closes #1691
barmac added a commit that referenced this issue Jul 7, 2022
@barmac
feat: add alignment and distribution menu multi-element context pad
8218ec3 
Closes #1680
Closes #1691
@fake-join fake-join bot closed this as completed in #1682 Jul 7, 2022
@bpmn-io-tasks bpmn-io-tasks bot removed the needs review Review pending label Jul 7, 2022
fake-join bot pushed a commit that referenced this issue Jul 7, 2022
@barmac @fake-join
feat: add alignment and distribution menu multi-element context pad
befe8b8 
Closes #1680
Closes #1691
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@barmac barmac

Labels
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add alignment and distribution buttons to the context pad bpmn-io/bpmn-js
1 participant
@barmac