Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unnecessary scrollbar appears on pages that include bpmn.js #1692

Closed
OmranAbazid opened this issue Jul 6, 2022 · 2 comments · Fixed by #1698
Closed

Unnecessary scrollbar appears on pages that include bpmn.js #1692

OmranAbazid opened this issue Jul 6, 2022 · 2 comments · Fixed by #1698
Assignees
@nikku
Labels
bug Something isn't working

Comments

@OmranAbazid
Copy link

OmranAbazid commented Jul 6, 2022 •
edited by nikku

Describe the Bug

There is an unnecessary scrollbar appearing on pages that include bpmn.js

This is caused by a weird svg element on the page named: 'helper-svg'
Screenshot 2022-07-06 at 11 40 43 AM

Steps to Reproduce

  1. Go to https://demo.bpmn.io/s/start (preferably on Windows)
  2. You will see a scrollbar as shown:

image

Expected Behavior

No scrollbar should appear

Environment

  • Browser: Chrome, 103
  • OS: Windows 11
  • Library version: 9.2.2

Depends on bpmn-io/diagram-js#657
@OmranAbazid OmranAbazid added the bug Something isn't working label Jul 6, 2022
nikku added a commit to bpmn-io/diagram-js that referenced this issue Jul 6, 2022
@nikku
fix(util): properly assign helper-svg styles
c74e07e 
Related to bpmn-io/bpmn-js#1692
nikku added a commit to bpmn-io/diagram-js that referenced this issue Jul 6, 2022
@nikku
fix(util): properly assign helper-svg styles
3a96849 
Related to bpmn-io/bpmn-js#1692
@nikku nikku mentioned this issue Jul 6, 2022
Merged
@nikku
Copy link
Member

nikku commented Jul 6, 2022

Thanks for opening this issue. Weird element indeed.

Fixed upstream via bpmn-io/diagram-js#657

@nikku nikku added the fixed upstream Requires integration of upstream change label Jul 6, 2022
@nikku nikku added the needs review Review pending label Jul 11, 2022 — with bpmn-io-tasks
@nikku nikku removed the fixed upstream Requires integration of upstream change label Jul 11, 2022
fake-join bot pushed a commit to bpmn-io/diagram-js that referenced this issue Jul 11, 2022
@nikku @fake-join
fix(util): properly assign helper-svg styles
911909b 
Related to bpmn-io/bpmn-js#1692
@nikku nikku added the fixed upstream Requires integration of upstream change label Jul 11, 2022 — with bpmn-io-tasks
@nikku nikku removed the needs review Review pending label Jul 11, 2022
nikku added a commit that referenced this issue Jul 12, 2022
@nikku
deps: update to diagram-js@8.7.1
2f5b398 
Closes #1692
@nikku nikku mentioned this issue Jul 12, 2022
Merged
@bpmn-io-tasks bpmn-io-tasks bot added the needs review Review pending label Jul 12, 2022
@bpmn-io-tasks bpmn-io-tasks bot removed the fixed upstream Requires integration of upstream change label Jul 12, 2022
fake-join bot pushed a commit that referenced this issue Jul 13, 2022
@nikku @fake-join
deps: update to diagram-js@8.7.1
5a75bab 
Closes #1692
@nikku
Copy link
Member

nikku commented Jul 14, 2022

Closed via 5a75bab.

@nikku nikku closed this as completed Jul 14, 2022
@bpmn-io-tasks bpmn-io-tasks bot removed the needs review Review pending label Jul 14, 2022
nikku added a commit that referenced this issue Aug 17, 2022
@nikku
deps: update to diagram-js@8.7.1
bdaa72b 
Closes #1692
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nikku nikku

Labels
bug Something isn't working
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Bump diagram js bpmn-io/bpmn-js
2 participants
@nikku @OmranAbazid